From reviews-return-74122-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Thu Mar 1 10:52:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9FEE218064D for ; Thu, 1 Mar 2018 10:52:08 +0100 (CET) Received: (qmail 84209 invoked by uid 500); 1 Mar 2018 09:52:07 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 84181 invoked by uid 99); 1 Mar 2018 09:52:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Mar 2018 09:52:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7B54C180677; Thu, 1 Mar 2018 09:52:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.376 X-Spam-Level: ** X-Spam-Status: No, score=2.376 tagged_above=-999 required=6.31 tests=[FORGED_HOTMAIL_RCVD2=1.187, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id UUYjjDjJBHyc; Thu, 1 Mar 2018 09:52:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4BE685F173; Thu, 1 Mar 2018 09:52:03 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DAE12E00A7; Thu, 1 Mar 2018 09:52:02 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id C4B50C40017; Thu, 1 Mar 2018 09:52:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5298226779372488809==" MIME-Version: 1.0 Subject: Review Request 65863: Updated mesos code with the new `os::system`. From: Akash Gupta To: Joseph Wu , Andrew Schwartzmeyer , Michael Park Cc: Akash Gupta , mesos Date: Thu, 01 Mar 2018 09:52:02 -0000 Message-ID: <20180301095202.29819.769@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Akash Gupta X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65863/ X-Sender: Akash Gupta Reply-To: Akash Gupta X-ReviewRequest-Repository: mesos --===============5298226779372488809== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65863/ ----------------------------------------------------------- Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park. Bugs: MESOS-4549 https://issues.apache.org/jira/browse/MESOS-4549 Repository: mesos Description ------- `os::system`'s return type was changed from `int` to `Option`, so the code in mesos was changed accordingly. Diffs ----- src/slave/containerizer/mesos/launch.cpp 75b7eaf9cd62d6b5f02896175168b651f4517e12 src/tests/containerizer/cgroups_isolator_tests.cpp 59b23be78efb4025bfef53a19ab97d9873ab8dc9 src/tests/containerizer/memory_pressure_tests.cpp 0c3e738ce05553a2ee5c38c6748d6d28a1eb93d3 src/tests/environment.cpp 1cba274e0e684b123ce1e4d9cd296f428022fcdc Diff: https://reviews.apache.org/r/65863/diff/1/ Testing ------- Thanks, Akash Gupta --===============5298226779372488809==--