mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66255: Temporarily disabled CSI proto compilation when gRPC is disabled.
Date Sat, 24 Mar 2018 05:13:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66255/#review199925
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66210, 66255]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 23, 2018, 8:44 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66255/
> -----------------------------------------------------------
> 
> (Updated March 23, 2018, 8:44 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Jie Yu, James Peach, Kapil Arya, and Zhitao Li.
> 
> 
> Bugs: MESOS-8724
>     https://issues.apache.org/jira/browse/MESOS-8724
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `major` and `minor` macros defined on some systems conflict with
> field names in the CSI spec proto, so its compilation is temporarily
> disabled for now until CSI is bumped to 0.2, where those field are
> removed.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 3b04e6353979c05a38f1b032704dce566d8fd561 
>   src/Makefile.am 56ce55480553c08450830987f217d0abedd5b2b8 
>   src/slave/flags.cpp dd8dfb7a8a9f7c6030939c9eea841eb47deadfc4 
>   src/slave/slave.cpp e76daabad0d2d68aa42d1da809d4a23459eaaacb 
> 
> 
> Diff: https://reviews.apache.org/r/66255/diff/2/
> 
> 
> Testing
> -------
> 
> `make check` on CentOS (w/ and w/o gRPC) and Mac (w/o gRPC)
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message