mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'.
Date Thu, 22 Mar 2018 21:17:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66210/#review199808
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66210]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 22, 2018, 9:37 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66210/
> -----------------------------------------------------------
> 
> (Updated March 22, 2018, 9:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.
> 
> 
> Bugs: MESOS-8719
>     https://issues.apache.org/jira/browse/MESOS-8719
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As 'test_csi_plugin' uses functionality that will only compile on Linux,
> we have to make sure that it isn't build on non-Linux systems.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 56ce55480553c08450830987f217d0abedd5b2b8 
> 
> 
> Diff: https://reviews.apache.org/r/66210/diff/1/
> 
> 
> Testing
> -------
> 
> make check (on macOS, configured with `--enable-grpc`)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message