-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66126/#review199699
-----------------------------------------------------------
src/tests/slave_tests.cpp
Lines 4698-4703 (original), 4696-4701 (patched)
<https://reviews.apache.org/r/66126/#comment280110>
Indented too far.
- Greg Mann
On March 19, 2018, 6:43 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66126/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 6:43 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This helps to encapsulate a task launch into a single
> future which will come in handy when enforcing the task
> launch order.
>
> This patch also consolidated the error handling code
> in the task launch path.
>
> Affected tests are also updated.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 37f0361251524e63d02d251e8a03901812b8affb
> src/slave/slave.cpp 915d4f1bbd642ca5d2587cfdd846262cb7e08788
> src/tests/mock_slave.hpp 8ec2b65a75f774d970ef6507df8b0c02fda5f2fd
> src/tests/mock_slave.cpp 8ec55b6aa84dd8b1c3743cbcdc246311585d0f63
> src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354
>
>
> Diff: https://reviews.apache.org/r/66126/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
|