mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 66147: Fixed disconnection for ATTACH_CONTAINER_INPUT call in IOSwitchboard.
Date Mon, 19 Mar 2018 21:41:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66147/
-----------------------------------------------------------

(Updated March 19, 2018, 9:41 p.m.)


Review request for mesos, Alexander Rukletsov, Joseph Wu, and Kevin Klues.


Bugs: MESOS-8545
    https://issues.apache.org/jira/browse/MESOS-8545


Repository: mesos


Description (updated)
-------

Previously, http response for ATTACH_CONTAINER_INPUT call could be lost
due to immediate termination of IOSwitchboard process after termination
of IOSwitchboard actor. Since IOSwitchboard didn't wait for completion
of sending all responses back to the agent, the agent received
disconnection error. To fix the issue, this patch adds finalization
of libprocess before returning from IOSwitchboard's main function.


Diffs
-----

  src/slave/containerizer/mesos/io/switchboard_main.cpp 0ff58e1b9dd7cddfebaf5d45c0562da1dcabf11b



Diff: https://reviews.apache.org/r/66147/diff/1/


Testing
-------

make check (Fedora 25)


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message