mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhi...@apache.org>
Subject Re: Review Request 66140: Fixed bug in `Framework::removeOperation()`.
Date Mon, 19 Mar 2018 20:23:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66140/#review199467
-----------------------------------------------------------




src/master/master.hpp
Lines 2628 (patched)
<https://reviews.apache.org/r/66140/#comment279776>

    A more higher level question: I wonder whether there is a more structured way to kee `Framework::operationUUIDs`
and  `Framework::operations` in sync.
    
    [Boost.Bimap](http://www.boost.org/doc/libs/1_66_0/libs/bimap/doc/html/index.html) might
be one of the possible ways? I have not used this for long and need to refresh my memory on
it.


- Zhitao Li


On March 19, 2018, 11:40 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66140/
> -----------------------------------------------------------
> 
> (Updated March 19, 2018, 11:40 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes `Framework::removeOperation()` keep
> `Framework::operationUUIDs` in-sync with `Framework::operations`.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp a54b8fab0d80806063045362079fc266afec7ac2 
> 
> 
> Diff: https://reviews.apache.org/r/66140/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message