mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.
Date Thu, 15 Mar 2018 19:10:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66049/#review199283
-----------------------------------------------------------




include/mesos/mesos.proto
Lines 1920-1921 (patched)
<https://reviews.apache.org/r/66049/#comment279588>

    As we discussed, let's do `s/PERSISTENT_//`, as well as `s/Persistent//` and `s/persistent_//`
below.



include/mesos/mesos.proto
Lines 1975 (patched)
<https://reviews.apache.org/r/66049/#comment279590>

    I'm thinking that, instead of asking the framework to craft the freed disk, we could leave
it to the agent/RP so they have the freedom to transform the freed disk to an appropriate
type of disk resource (although for now it will be the same as the original volume except
in size and persistence). So how about having a `Scalar target` instead, and we can implement
it through `Resources::shrink()`?


- Chun-Hung Hsiao


On March 13, 2018, 10:48 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66049/
> -----------------------------------------------------------
> 
> (Updated March 13, 2018, 10:48 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Gaston Kleiman.
> 
> 
> Bugs: MESOS-4965
>     https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added offer operation to grow and shrink persistent volumes.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto e6ba3746456c9241ceaefac39200f68562dd5cb9 
>   include/mesos/v1/mesos.proto 30d4d35e865db2af1ba85b12e2b5b0e499ef8de8 
> 
> 
> Diff: https://reviews.apache.org/r/66049/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message