mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 64970: Use tox for linting and testing code living uder src/python.
Date Wed, 14 Mar 2018 15:57:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64970/#review199174
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['64970']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64970

Relevant logs:

- [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64970/logs/libprocess-tests-stdout.log):

```
[ RUN      ] TimeTest.Output
[       OK ] TimeTest.Output (0 ms)
[----------] 4 tests from TimeTest (4 ms total)

[----------] 3 tests from TimeSeriesTest
[ RUN      ] TimeSeriesTest.Set
[       OK ] TimeSeriesTest.Set (0 ms)
[ RUN      ] TimeSeriesTest.Sparsify
[       OK ] TimeSeriesTest.Sparsify (1 ms)
[ RUN      ] TimeSeriesTest.Truncate
[       OK ] TimeSeriesTest.Truncate (1 ms)
[----------] 3 tests from TimeSeriesTest (5 ms total)

[----------] 3 tests from JWTTest
[ RUN      ] JWTTest.Parse
[       OK ] JWTTest.Parse (7 ms)
[ RUN      ] JWTTest.Create
[       OK ] JWTTest.Create (1 ms)
[ RUN      ] JWTTest.Stringify
[       OK ] JWTTest.Stringify (0 ms)
[----------] 3 tests from JWTTest (11 ms total)

[----------] 1 test from SSL
[ RUN      ] SSL.Disabled
[       OK ] SSL.Disabled (9 ms)
[----------] 1 test from SSL (9 ms total)

[----------] 17 tests from SSLTest
[ RUN      ] SSLTest.SSLSocket
```

- [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64970/logs/libprocess-tests-stderr.log):

```
ABORT: (D:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp:171): Could
not generate certificate: Failed to set common name: X509_NAME_add_entry_by_txt
```

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64970/logs/mesos-tests-stdout.log):

```
[       OK ] ContentType/SchedulerTest.Revive/1 (259 ms)
[ RUN      ] ContentType/SchedulerTest.Suppress/0
[       OK ] ContentType/SchedulerTest.Suppress/0 (242 ms)
[ RUN      ] ContentType/SchedulerTest.Suppress/1
[       OK ] ContentType/SchedulerTest.Suppress/1 (246 ms)
[ RUN      ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0
[       OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0 (239 ms)
[ RUN      ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1
[       OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1 (254 ms)
[ RUN      ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0
[       OK ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0 (285
ms)
[ RUN      ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1
[       OK ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1 (320
ms)
[ RUN      ] ContentType/SchedulerTest.Message/0
[       OK ] ContentType/SchedulerTest.Message/0 (315 ms)
[ RUN      ] ContentType/SchedulerTest.Message/1
[       OK ] ContentType/SchedulerTest.Message/1 (319 ms)
[ RUN      ] ContentType/SchedulerTest.Request/0
[       OK ] ContentType/SchedulerTest.Request/0 (100 ms)
[ RUN      ] ContentType/SchedulerTest.Request/1
[       OK ] ContentType/SchedulerTest.Request/1 (101 ms)
[ RUN      ] ContentType/SchedulerTest.SchedulerReconnect/0
[       OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (90 ms)
[ RUN      ] ContentType/SchedulerTest.SchedulerReconnect/1
[       OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (85 ms)
[----------] 32 tests from ContentType/SchedulerTest (15049 ms total)

[----------] 4 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN      ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64970/logs/mesos-tests-stderr.log):

```
I0314 15:57:02.337544  9132 master.cpp:1673] Recovering from registrar
I0314 15:57:02.338690 10996 registrar.cpp:391] Successfully fetched the registry (0B) in 1.145088ms
I0314 15:57:02.338690 10996 registrar.cpp:495] Applied 1 operations in 0ns; attempting to
update the registry
I0314 15:57:02.339540  1140 registrar.cpp:552] Successfully updated the registry in 850944ns
I0314 15:57:02.339540  1140 registrar.cpp:424] Successfully recovered registrar
I0314 15:57:02.340536  9100 master.cpp:1787] Recovered 0 agents from the registry (239B);
allowing 10mins for agents to reregister
I0314 15:57:02.356540 11656 scheduler.cpp:188] Version: 1.6.0
I0314 15:57:02.357491  7076 scheduler.cpp:311] Using default 'basic' HTTP authenticatee
I0314 15:57:02.357491  6628 scheduler.cpp:494] New master detected at master@10.3.1.9:51848
I0314 15:57:02.366562 12228 scheduler.cpp:468] Re-detecting master
I0314 15:57:02.367517 12228 scheduler.cpp:494] New master detected at master@10.3.1.9:51848
I0314 15:57:02.374492  9132 scheduler.cpp:472] Lost leading master
I0314 15:57:02.378545 11656 master.cpp:1131] Master terminating
I0314 15:57:02.401489 11656 cluster.cpp:172] Creating default 'local' authorizer
I0314 15:57:02.407532  7888 master.cpp:458] Master c6dfd569-7ff8-4e3d-9a73-bcadcdc7e3b3 (win-bld-srv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
started on 10.3.1.9:51848
I0314 15:57:02.407532  7888 master.cpp:460] Flags at startup: --acls="" --agent_ping_timeout="15secs"
--agent_reregister_timeout="10mins" --allocation_interval="1secs" --allocator="HierarchicalDRF"
--authenticate_agents="true" --authenticate_frameworks="true" --authenticate_http_frameworks="true"
--authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticators="crammd5"
--authorizers="local" --credentials="C:\Users\mesos\AppData\Local\Temp\XxeSWM\credentials"
--filter_gpu_resources="true" --framework_sorter="drf" --help="false" --hostname_lookup="true"
--http_authenticators="basic" --http_framework_authenticators="basic" --initialize_driver_logging="true"
--log_auto_initialize="true" --logbufsecs="0" --logging_level="INFO" --max_agent_ping_timeouts="5"
--max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" --max_unreachable_tasks_per_framework="1000"
--port="5050" --quiet="false" --recovery_agent_removal_limit="100%" --registry="in_memory"
  --registry_fetch_timeout="1mins" --registry_gc_interval="15mins" --registry_max_agent_age="2weeks"
--registry_max_agent_count="102400" --registry_store_timeout="100secs" --registry_strict="false"
--require_agent_domain="false" --root_submissions="true" --user_sorter="drf" --version="false"
--webui_dir="/webui" --work_dir="C:\Users\mesos\AppData\Local\Temp\XxeSWM\master" --zk_session_timeout="10secs"
I0314 15:57:02.410532  7888 master.cpp:509] Master only allowing authenticated frameworks
to register
I0314 15:57:02.410532  7888 master.cpp:515] Master only allowing authenticated agents to register
I0314 15:57:02.410532  7888 master.cpp:521] Master only allowing authenticated HTTP frameworks
to register
I0314 15:57:02.410532  7888 credentials.hpp:37] Loading credentials for authentication from
'C:\Users\mesos\AppData\Local\Temp\XxeSWM\credentials'
I0314 15:57:02.411494  7888 master.cpp:565] Using default 'crammd5' authenticator
I0314 15:57:02.413538  7888 http.cpp:1045] Creating default 'basic' HTTP authenticator for
realm 'mesos-master-readonly'
I0314 15:57:02.413538  7888 http.cpp:1045] Creating default 'basic' HTTP authenticator for
realm 'mesos-master-readwrite'
I0314 15:57:02.414546  7888 http.cpp:1045] Creating default 'basic' HTTP authenticator for
realm 'mesos-master-scheduler'
I0314 15:57:02.414546  7888 master.cpp:644] Authorization enabled
I0314 15:57:02.423549  1140 master.cpp:2114] Elected as the leading master!
I0314 15:57:02.423549  1140 master.cpp:1673] Recovering from registrar
I0314 15:57:02.424548 12228 registrar.cpp:391] Successfully fetched the registry (0B) in 999168ns
I0314 15:57:02.ABORT: (D:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp:171):
Could not generate certificate: Failed to set common name: X509_NAME_add_entry_by_txt
```

- Mesos Reviewbot Windows


On March 14, 2018, 4:05 p.m., Eric Chung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64970/
> -----------------------------------------------------------
> 
> (Updated March 14, 2018, 4:05 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use tox for linting and testing code living uder src/python.
> 
> At the moment, all linting is done through the same `pylint`
> installation under support/.virtualenv, which requires ALL dependencies
> (i.e. pip-requirements.txt, requirements.in scattered in various
> directories) to be installed in the same virtualenv, making things
> really messy -- e.g. when I've changed some code under `src/python/lib`,
> but don't have the dev virtualenv activated, linting will fail since
> none of the dependencies under `src/python/lib` have been installed.
> 
> Using tox, we can solve this problem by distributing a "test spec"
> (tox.ini) in each of the python source directories which are aware of
> its local dependencies only. To test or lint the code there would be as
> simple as running `tox -e py27-lint <file_path>`, and the corresponding
> virtualenv and test dependencies would automatically be setup.
> 
> This patch modifies `support/mesos-style.py` to install `tox` in
> `support/.virtualenv` and delegates linting to a `tox` call when it sees
> python directories that have tox setup for it. Linting for all other
> languages will not be effected.
> 
> Testing Done:
> 1. intentionally create a lint error, such as extra spaces before a
> parens in a python file
> 2. run the pre-commit hook and see tox in action
> 
> Reviewed at https://reviews.apache.org/r/64970/
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/tests/__init__.py PRE-CREATION 
>   src/python/cli_new/tox.ini PRE-CREATION 
>   src/python/lib/requirements-test.in b2b73aab65377d9310797203ea84c5150ae60805 
>   src/python/lib/tox.ini fd5e89c77c8608fea21e9caad814c6e111ad57db 
>   support/mesos-style.py 47ec36949010fa511d1b3974739c5ad5c03f6f7f 
> 
> 
> Diff: https://reviews.apache.org/r/64970/diff/6/
> 
> 
> Testing
> -------
> 
> 1. intentionally create a lint error, such as extra spaces before a parens in a python
file
> 2. run the pre-commit hook and see tox in action
> 
> 
> Thanks,
> 
> Eric Chung
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message