mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kordich via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.
Date Thu, 08 Mar 2018 19:22:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/
-----------------------------------------------------------

(Updated March 8, 2018, 7:22 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.


Changes
-------

Addressed comments and added regression test


Bugs: MESOS-8646
    https://issues.apache.org/jira/browse/MESOS-8646


Repository: mesos


Description
-------

Changed flags to CreateFile to support Windows symlink path resolution.


Diffs (updated)
-----

  3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d

  3rdparty/stout/tests/os/filesystem_tests.cpp b84f1ae17246d94947538efeaf504a2cd247f20e 


Diff: https://reviews.apache.org/r/65936/diff/2/

Changes: https://reviews.apache.org/r/65936/diff/1-2/


Testing
-------

I encountered a permissions error stating "The process cannot access the file because it is
being used by another process." when attempting to download stderr/stdout from a task running
on a Windows agent, or when attempting to download the mesos agent log on a Windows agent.


After some very helpful information from Andy and Akash, I made this change and confirmed
it fixed this issue with the task/agent logs.

I also ran the automated tests on Windows and all tests pass.

I did not test this on Linux, but because this file is compiled only on Windows, it shouldn't
be necessary.


Thanks,

John Kordich


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message