mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 65334: Added quota limit to the master API protos.
Date Thu, 08 Mar 2018 00:33:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65334/#review198834
-----------------------------------------------------------




include/mesos/v1/quota/quota.proto
Lines 38-40 (original), 30 (patched)
<https://reviews.apache.org/r/65334/#comment279089>

    `QuotaInfo` is used as internal message. Users will most likely look at `QuotaRequest`,
these user-facing comments are better to be placed in `QuotaRequest`?



include/mesos/v1/quota/quota.proto
Lines 46-49 (original), 36-82 (patched)
<https://reviews.apache.org/r/65334/#comment279079>

    As discussed offline, let's give more thoughts on `force` semantic. What kind of check
do we want to do regarding guarantee? Do we want to check the attainability of limit?



include/mesos/v1/quota/quota.proto
Line 57 (original), 93-94 (patched)
<https://reviews.apache.org/r/65334/#comment279078>

    This `force` flag is used for both guarantee and limit. What if the user only wants to
`force` one of the fields?
    
    Also as discussed offline, one alternative is to not have the `force` option all-together.


- Meng Zhu


On Feb. 23, 2018, 2:23 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65334/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2018, 2:23 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Meng Zhu.
> 
> 
> Bugs: MESOS-8487
>     https://issues.apache.org/jira/browse/MESOS-8487
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This introduces a `limit` in `QuotaInfo` and `QuotaRequest`.
> 
> A new `UPDATE_QUOTA` master call is added as a replacement of
> `SET_QUOTA` and `REMOVE_QUOTA`, which provides the new semantics
> of unset limit meaning "no limit" and unset guarantee meaning
> "no guarantee".
> 
> The new APIs are marked as experimental for now.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto f40caa2a6338ff58a325444cfb72cd24f2c99472 
>   include/mesos/quota/quota.proto f2ed6f555e1e7b0290fefa3e301c9bdbf550bd11 
>   include/mesos/v1/master/master.proto 67c9560eaa7bd6b20b73af07f7666f0d98c4453d 
>   include/mesos/v1/quota/quota.proto 5dd772fee46f740b062827ed7c9704c26187cb12 
>   src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad 
>   src/master/validation.cpp 9254cd22e67d9aca53135701575fb0857ff6f7d6 
> 
> 
> Diff: https://reviews.apache.org/r/65334/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message