mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 65863: Updated mesos code with the new `os::system`.
Date Thu, 01 Mar 2018 09:52:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65863/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.


Bugs: MESOS-4549
    https://issues.apache.org/jira/browse/MESOS-4549


Repository: mesos


Description
-------

`os::system`'s return type was changed from `int` to `Option<int>`, so
the code in mesos was changed accordingly.


Diffs
-----

  src/slave/containerizer/mesos/launch.cpp 75b7eaf9cd62d6b5f02896175168b651f4517e12 
  src/tests/containerizer/cgroups_isolator_tests.cpp 59b23be78efb4025bfef53a19ab97d9873ab8dc9

  src/tests/containerizer/memory_pressure_tests.cpp 0c3e738ce05553a2ee5c38c6748d6d28a1eb93d3

  src/tests/environment.cpp 1cba274e0e684b123ce1e4d9cd296f428022fcdc 


Diff: https://reviews.apache.org/r/65863/diff/1/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message