From reviews-return-73793-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Wed Feb 21 22:07:55 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D0E5B18061A for ; Wed, 21 Feb 2018 22:07:54 +0100 (CET) Received: (qmail 32508 invoked by uid 500); 21 Feb 2018 21:07:53 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 32486 invoked by uid 99); 21 Feb 2018 21:07:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Feb 2018 21:07:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B639FC1585; Wed, 21 Feb 2018 21:07:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.127 X-Spam-Level: ** X-Spam-Status: No, score=2.127 tagged_above=-999 required=6.31 tests=[FORGED_HOTMAIL_RCVD2=1.187, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id fu1iQN6bHHMY; Wed, 21 Feb 2018 21:07:52 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B6E415F17F; Wed, 21 Feb 2018 21:07:51 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 54728E012D; Wed, 21 Feb 2018 21:07:51 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 006B0C4013A; Wed, 21 Feb 2018 21:07:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2553300990472051878==" MIME-Version: 1.0 Subject: Re: Review Request 65624: Added fetcher tests for `stderr` output. From: Akash Gupta To: Jie Yu , Akash Gupta , Joseph Wu , Jeff Coffler Cc: Andrew Schwartzmeyer , mesos Date: Wed, 21 Feb 2018 21:07:48 -0000 Message-ID: <20180221210748.27952.47811@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Akash Gupta X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65624/ X-Sender: Akash Gupta X-ReviewBoard-ShipIt: 1 References: <20180220194021.2548.54451@reviews-vm2.apache.org> In-Reply-To: <20180220194021.2548.54451@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Akash Gupta X-ReviewRequest-Repository: mesos --===============2553300990472051878== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65624/#review198054 ----------------------------------------------------------- Ship it! Ship It! - Akash Gupta On Feb. 20, 2018, 7:40 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65624/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2018, 7:40 p.m.) > > > Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The fetcher is supposed to log its `stderr` output to a redirected file > called `stderr` in the given sandbox directory. There previously existed > a bug on Windows due to incorrect handle inheritance where this > redirection failed silently, leaving the log empty. These unit tests > assert that the correct content is logged to the `stderr` file for both > a success and failure fetch scenario. > > > Diffs > ----- > > src/tests/fetcher_tests.cpp 1b4ba1d286f218731c13180e5189e91f90e3d63f > > > Diff: https://reviews.apache.org/r/65624/diff/1/ > > > Testing > ------- > > Windows (Linux pending): > ``` > [ RUN ] FetcherTest.LogSuccessToStderr > [ OK ] FetcherTest.LogSuccessToStderr (197 ms) > [ RUN ] FetcherTest.LogFailureToStderr > [ OK ] FetcherTest.LogFailureToStderr (320 ms) > ``` > > > Thanks, > > Andrew Schwartzmeyer > > --===============2553300990472051878==--