From reviews-return-73607-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Wed Feb 21 14:58:38 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E394318061A for ; Wed, 21 Feb 2018 14:58:37 +0100 (CET) Received: (qmail 83897 invoked by uid 500); 21 Feb 2018 13:58:37 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 83657 invoked by uid 99); 21 Feb 2018 13:58:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Feb 2018 13:58:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id AF5E0C0A8E; Wed, 21 Feb 2018 13:58:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.127 X-Spam-Level: ** X-Spam-Status: No, score=2.127 tagged_above=-999 required=6.31 tests=[FORGED_HOTMAIL_RCVD2=1.187, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Z0krse8D9PCR; Wed, 21 Feb 2018 13:58:35 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 663585F124; Wed, 21 Feb 2018 13:58:34 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A8238E00B8; Wed, 21 Feb 2018 13:58:33 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8DAB7C40137; Wed, 21 Feb 2018 13:58:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5997293592404757387==" MIME-Version: 1.0 Subject: Review Request 65621: Added docker constants and common functions file. From: Akash Gupta To: Akash Gupta , mesos Date: Wed, 21 Feb 2018 13:58:33 -0000 Message-ID: <20180221135833.28022.70243@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Akash Gupta X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65621/ X-Sender: Akash Gupta Reply-To: Akash Gupta X-ReviewRequest-Repository: mesos --===============5997293592404757387== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65621/ ----------------------------------------------------------- Review request for mesos. Repository: mesos Description ------- This patch is in preparation of porting docker tests to Windows. There were a few hardcoded values that were used throughout the codebase, such as the `alpine` image, that are defined as a constant in a single file. Testing ------- Thanks, Akash Gupta --===============5997293592404757387==--