From reviews-return-73455-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Fri Feb 16 01:36:56 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id ACFA118064A for ; Fri, 16 Feb 2018 01:36:55 +0100 (CET) Received: (qmail 62361 invoked by uid 500); 16 Feb 2018 00:36:54 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 62346 invoked by uid 99); 16 Feb 2018 00:36:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Feb 2018 00:36:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9FA4F1800EB; Fri, 16 Feb 2018 00:36:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.939 X-Spam-Level: X-Spam-Status: No, score=0.939 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 7u9IsqJy3reI; Fri, 16 Feb 2018 00:36:52 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CE11E5F18B; Fri, 16 Feb 2018 00:36:51 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A0EAFE00C9; Fri, 16 Feb 2018 00:36:50 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 201C1C4015D; Fri, 16 Feb 2018 00:36:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1298458774196700000==" MIME-Version: 1.0 Subject: Re: Review Request 65575: Removed redundant comment from the command executor. From: Greg Mann To: Anand Mazumdar , Qian Zhang , Greg Mann , Vinod Kone Cc: Gaston Kleiman , mesos Date: Fri, 16 Feb 2018 00:36:49 -0000 Message-ID: <20180216003649.58301.17608@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65575/ X-Sender: Greg Mann X-ReviewBoard-ShipIt: 1 References: <20180208194952.11085.6230@reviews-vm2.apache.org> In-Reply-To: <20180208194952.11085.6230@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============1298458774196700000== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65575/#review197654 ----------------------------------------------------------- Ship it! Ship It! - Greg Mann On Feb. 8, 2018, 7:49 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65575/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2018, 7:49 p.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Removed redundant comment from the command executor. > > > Diffs > ----- > > src/launcher/executor.cpp 050f5a057f360873e2b4738b126289bcd1bd0c7f > > > Diff: https://reviews.apache.org/r/65575/diff/1/ > > > Testing > ------- > > Not a functional change. > > > Thanks, > > Gaston Kleiman > > --===============1298458774196700000==--