From reviews-return-73420-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Wed Feb 14 18:58:12 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id AD9FA180621 for ; Wed, 14 Feb 2018 18:58:11 +0100 (CET) Received: (qmail 12210 invoked by uid 500); 14 Feb 2018 17:58:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 12199 invoked by uid 99); 14 Feb 2018 17:58:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Feb 2018 17:58:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9E531C0118; Wed, 14 Feb 2018 17:58:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.941 X-Spam-Level: X-Spam-Status: No, score=0.941 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id qWqnRhWTj_vt; Wed, 14 Feb 2018 17:58:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 316025F17F; Wed, 14 Feb 2018 17:58:08 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D0E2CE00D5; Wed, 14 Feb 2018 17:58:07 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A45DAC40017; Wed, 14 Feb 2018 17:58:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5733412632725169896==" MIME-Version: 1.0 Subject: Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'. From: Benno Evers To: Andrei Budnik , Vinod Kone Cc: Mesos Reviewbot , Mesos Reviewbot Windows , Benno Evers , mesos Date: Wed, 14 Feb 2018 17:58:07 -0000 Message-ID: <20180214175807.60662.45131@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benno Evers X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65571/ X-Sender: Benno Evers References: <20180213211542.2972.55954@reviews-vm2.apache.org> In-Reply-To: <20180213211542.2972.55954@reviews-vm2.apache.org> Reply-To: Benno Evers X-ReviewRequest-Repository: mesos --===============5733412632725169896== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 13, 2018, 9:15 p.m., Andrei Budnik wrote: > > src/master/master.cpp > > Lines 2182-2185 (patched) > > > > > > Why do we need this case? What problem does it solve? It mainly ensures that the proposed fix changes only the problematic behaviour that was observed, and otherwise leaves the visible behaviour of the master the same as before. If it turns out that this case is indeed unnecessary, I think it should be removed in a separate review. - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review197434 ----------------------------------------------------------- On Feb. 13, 2018, 8:05 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65571/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2018, 8:05 p.m.) > > > Review request for mesos, Andrei Budnik and Vinod Kone. > > > Bugs: MESOS-8550 > https://issues.apache.org/jira/browse/MESOS-8550 > > > Repository: mesos > > > Description > ------- > > The function `MasterDetector::detect()` returns a value of type > `Future>`, which, according to its documentation, > can be `None` if an election occured and no master is elected. > > However, the code in `Master::detected()` was only handling the > cases of a failed future or a valid `MasterInfo` object. > > > Diffs > ----- > > src/master/master.cpp d7d22866f7a4eb87bd8949efafc97e828e7d4b94 > src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9 > src/tests/master_tests.cpp 28663c7a77096943949350abb3d13f9c04505f5b > > > Diff: https://reviews.apache.org/r/65571/diff/3/ > > > Testing > ------- > > `./mesos-tests` > > > Thanks, > > Benno Evers > > --===============5733412632725169896==--