From reviews-return-73403-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Wed Feb 14 11:13:02 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E0148180621 for ; Wed, 14 Feb 2018 11:13:01 +0100 (CET) Received: (qmail 97130 invoked by uid 500); 14 Feb 2018 10:13:01 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 97110 invoked by uid 99); 14 Feb 2018 10:13:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Feb 2018 10:13:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C8D37C0627; Wed, 14 Feb 2018 10:12:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.391 X-Spam-Level: ** X-Spam-Status: No, score=2.391 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Qn9S4OU_ZMkO; Wed, 14 Feb 2018 10:12:59 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C17215F126; Wed, 14 Feb 2018 10:12:58 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 66121E00A6; Wed, 14 Feb 2018 10:12:58 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 4585AC4060B; Wed, 14 Feb 2018 10:12:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5111818588633580605==" MIME-Version: 1.0 Subject: Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure. From: Qian Zhang To: Anand Mazumdar , Qian Zhang , Greg Mann , Vinod Kone Cc: Gaston Kleiman , mesos Date: Wed, 14 Feb 2018 10:12:58 -0000 Message-ID: <20180214101258.60662.19238@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65551/ X-Sender: Qian Zhang X-ReviewBoard-ShipIt: 1 References: <20180212234132.6750.18576@reviews-vm2.apache.org> In-Reply-To: <20180212234132.6750.18576@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============5111818588633580605== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/#review197497 ----------------------------------------------------------- Ship it! Ship It! - Qian Zhang On Feb. 13, 2018, 7:41 a.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65551/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2018, 7:41 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone. > > > Bugs: MESOS-8468 > https://issues.apache.org/jira/browse/MESOS-8468 > > > Repository: mesos > > > Description > ------- > > The default executor would be completely shutdown on a > `LAUNCH_NESTED_CONTAINER` failure. > > This patch makes it kill the affected task group instead of shutting > down and killing all task groups. > > > Diffs > ----- > > src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea > > > Diff: https://reviews.apache.org/r/65551/diff/6/ > > > Testing > ------- > > `sudo make check` on GNU/Linux > > Regression test on https://reviews.apache.org/r/65552/ > > > Thanks, > > Gaston Kleiman > > --===============5111818588633580605==--