From reviews-return-73103-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Thu Feb 8 20:50:34 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 15FBD18064F for ; Thu, 8 Feb 2018 20:50:34 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 05A19160C5D; Thu, 8 Feb 2018 19:50:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4B17E160C34 for ; Thu, 8 Feb 2018 20:50:33 +0100 (CET) Received: (qmail 8441 invoked by uid 500); 8 Feb 2018 19:50:32 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 8424 invoked by uid 99); 8 Feb 2018 19:50:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Feb 2018 19:50:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5FD0FC17B0; Thu, 8 Feb 2018 19:50:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.94 X-Spam-Level: X-Spam-Status: No, score=0.94 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ElXTk8HwBpx6; Thu, 8 Feb 2018 19:50:30 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 645B55F2A8; Thu, 8 Feb 2018 19:50:29 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B6A40E012B; Thu, 8 Feb 2018 19:50:28 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8CAB4C4060B; Thu, 8 Feb 2018 19:50:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1676929920510749218==" MIME-Version: 1.0 Subject: Re: Review Request 65469: Windows: Updated `internal::process:createChildProcess`. From: Andrew Schwartzmeyer To: Jie Yu , Akash Gupta , Joseph Wu Cc: Andrew Schwartzmeyer , mesos Date: Thu, 08 Feb 2018 19:50:28 -0000 Message-ID: <20180208195028.11085.29774@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65469/ X-Sender: Andrew Schwartzmeyer References: <20180202201251.12716.49513@reviews-vm2.apache.org> In-Reply-To: <20180202201251.12716.49513@reviews-vm2.apache.org> Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============1676929920510749218== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65469/ ----------------------------------------------------------- (Updated Feb. 8, 2018, 11:50 a.m.) Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. Changes ------- Pretty much a new commit. Summary (updated) ----------------- Windows: Updated `internal::process:createChildProcess`. Bugs: MESOS-8512 https://issues.apache.org/jira/browse/MESOS-8512 Repository: mesos Description (updated) ------- The interface of `internal::windows:create_process` was changed to accept a `std::array` instead of a `std::tuple`. Furthermore, the error handling in `subprocess` was incorrect. We only need to check the success of `createChildProcess`; we do not need to check if `pid == -1` on Windows. We also now return the actual error from `create_process` if it errored, instead of the whole `Try`. The TODO about closing the child-ends of the file descriptors was resolved. We now close these in `createChildProcess`, immediately after `create_process`. This means we only have to do it once. Diffs (updated) ----- 3rdparty/libprocess/src/subprocess.cpp 785e2e1083d115d25fffde2df74ed8bc1726511c 3rdparty/libprocess/src/subprocess_windows.hpp 0183bb451f68528acf31ed97754320c64f35102b Diff: https://reviews.apache.org/r/65469/diff/2/ Changes: https://reviews.apache.org/r/65469/diff/1-2/ Testing ------- Thanks, Andrew Schwartzmeyer --===============1676929920510749218==--