From reviews-return-73033-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Wed Feb 7 22:14:02 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 7C6C1180677 for ; Wed, 7 Feb 2018 22:14:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6BF07160C3A; Wed, 7 Feb 2018 21:14:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BB5FC160C5C for ; Wed, 7 Feb 2018 22:14:01 +0100 (CET) Received: (qmail 24913 invoked by uid 500); 7 Feb 2018 21:14:01 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 24662 invoked by uid 99); 7 Feb 2018 21:14:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Feb 2018 21:14:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id AF7FCC0040; Wed, 7 Feb 2018 21:13:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.878 X-Spam-Level: * X-Spam-Status: No, score=1.878 tagged_above=-999 required=6.31 tests=[FORGED_HOTMAIL_RCVD2=1.187, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id H9ZvHnoIcRDC; Wed, 7 Feb 2018 21:13:58 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id AFCCE5F472; Wed, 7 Feb 2018 21:13:57 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 09A62E00B4; Wed, 7 Feb 2018 21:13:57 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3D881C400F6; Wed, 7 Feb 2018 21:13:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6171317143662994688==" MIME-Version: 1.0 Subject: Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`. From: Akash Gupta To: Jie Yu , Akash Gupta , Joseph Wu Cc: Andrew Schwartzmeyer , mesos Date: Wed, 07 Feb 2018 21:13:55 -0000 Message-ID: <20180207211355.29714.51821@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Akash Gupta X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65408/ X-Sender: Akash Gupta X-ReviewBoard-ShipIt: 1 References: <20180202001439.34684.78329@reviews-vm2.apache.org> In-Reply-To: <20180202001439.34684.78329@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Akash Gupta X-ReviewRequest-Repository: mesos --===============6171317143662994688== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65408/#review197043 ----------------------------------------------------------- Ship it! Ship It! - Akash Gupta On Feb. 2, 2018, 12:14 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65408/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2018, 12:14 a.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-6713 > https://issues.apache.org/jira/browse/MESOS-6713 > > > Repository: mesos > > > Description > ------- > > This commit enables the unit tests found in `slave_recovery_tests.cpp` > to test agent recovery on Windows. > > > Diffs > ----- > > src/tests/CMakeLists.txt 6f1c67a6b4003ada1a0635a68fb7471895a2a6f5 > src/tests/slave_recovery_tests.cpp 77aa60c953bd0769eaba05f001755e4cec9ba028 > > > Diff: https://reviews.apache.org/r/65408/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > > --===============6171317143662994688==--