From reviews-return-72713-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Thu Feb 1 07:12:00 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 20482180652 for ; Thu, 1 Feb 2018 07:12:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0E85A160C55; Thu, 1 Feb 2018 06:12:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 564C1160C42 for ; Thu, 1 Feb 2018 07:11:59 +0100 (CET) Received: (qmail 1559 invoked by uid 500); 1 Feb 2018 06:11:54 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 710 invoked by uid 99); 1 Feb 2018 06:11:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2018 06:11:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 838E4C0577; Thu, 1 Feb 2018 06:11:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.691 X-Spam-Level: X-Spam-Status: No, score=0.691 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id I5WNWCYiP_66; Thu, 1 Feb 2018 06:11:52 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4F14D5FAF7; Thu, 1 Feb 2018 06:11:52 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E52F9E00D2; Thu, 1 Feb 2018 06:11:51 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 1E7A6C40026; Thu, 1 Feb 2018 06:11:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6908114025026994443==" MIME-Version: 1.0 Subject: Re: Review Request 65427: Used unique CSI plugin names for SLRP tests. From: Gaston Kleiman To: Gaston Kleiman , Greg Mann Cc: Chun-Hung Hsiao , mesos Date: Thu, 01 Feb 2018 06:11:49 -0000 Message-ID: <20180201061149.59674.39867@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gaston Kleiman X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65427/ X-Sender: Gaston Kleiman X-ReviewBoard-ShipIt: 1 References: <20180131010036.30294.93269@reviews-vm2.apache.org> In-Reply-To: <20180131010036.30294.93269@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Gaston Kleiman X-ReviewRequest-Repository: mesos --===============6908114025026994443== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65427/#review196618 ----------------------------------------------------------- Ship it! Ship It! - Gaston Kleiman On Jan. 30, 2018, 5 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65427/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2018, 5 p.m.) > > > Review request for mesos, Gaston Kleiman and Greg Mann. > > > Bugs: MESOS-8399 > https://issues.apache.org/jira/browse/MESOS-8399 > > > Repository: mesos > > > Description > ------- > > To provide better test isolation, the SLRP tests would generate random > unique names in CSI plugin configs, so the plugin containers would use > different container IDs. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp e0b089ac96de4762f2c5ddae9716a38d9837d1bf > > > Diff: https://reviews.apache.org/r/65427/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > > --===============6908114025026994443==--