mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 65825: Added a test that Docker tasks can be killed when 'inspect' is hung.
Date Wed, 28 Feb 2018 00:39:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65825/
-----------------------------------------------------------

(Updated Feb. 28, 2018, 12:39 a.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.


Bugs: MESOS-8574
    https://issues.apache.org/jira/browse/MESOS-8574


Repository: mesos


Description (updated)
-------

Previously, the Mesos Docker executor waited for an initial
'docker inspect' call to return before making any progress after
task launch. This meant that in some cases where the Docker CLI
was not responsive, the executor could get into an unkillable
state. This patch adds a new test,
`HungDockerTest.ROOT_DOCKER_InspectHungDuringExecutorTaskLaunch`,
to verify that recent changes will allow a scheduler to
successfully kill a Docker task in such situations.


Diffs
-----

  src/tests/containerizer/docker_containerizer_tests.cpp 85e6f8739dd2d6f9119e30f13f681cf4b8dc45ed



Diff: https://reviews.apache.org/r/65825/diff/1/


Testing
-------

`sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectHungDuringExecutorTaskLaunch"`


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message