mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 65728: Add test to check quotes in docker executor health check.
Date Fri, 23 Feb 2018 02:21:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/#review198157
-----------------------------------------------------------



Patch looks great!

Reviews applied: [65393, 65394, 65395, 65396, 65419, 65127, 65615, 64387, 65727, 65733, 64604,
65728]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 22, 2018, 1:51 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65728/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2018, 1:51 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman,
and Joseph Wu.
> 
> 
> Bugs: MESOS-4812 and MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-4812
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
> the docker executor properly deals with quotes in the command health
> check to ensure that MESOS-4812 is fixed.
> 
> 
> Diffs
> -----
> 
>   src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab 
> 
> 
> Diff: https://reviews.apache.org/r/65728/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message