-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/#review198154
-----------------------------------------------------------
src/docker/docker.cpp
Lines 1314-1315 (patched)
<https://reviews.apache.org/r/65683/#comment278261>
I'm thinking I need to do something different to clean these things up, since `_inspect()`
is invoked repeatedly by the retry logic.
Probably better to register a single `onDiscard` callback in `inspect()`, which will perform
this cleanup on a couple of persistent containers which we reassign in the body of `_inspect()`.
- Greg Mann
On Feb. 22, 2018, 12:36 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65683/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2018, 12:36 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-8575
> https://issues.apache.org/jira/browse/MESOS-8575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated discard handling in Docker library functions.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28
>
>
> Diff: https://reviews.apache.org/r/65683/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
|