mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 65393: Fixed docker command health check to use the right docker socket.
Date Fri, 16 Feb 2018 23:25:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/
-----------------------------------------------------------

(Updated Feb. 16, 2018, 11:25 p.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.


Changes
-------

rebased


Bugs: MESOS-8498
    https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
-------

The original command health check was calling `docker exec` instead
of `docker -H <docker_socket> exec`, so it was ignoring the socket
value passed to the docker executor.


Diffs (updated)
-----

  src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61 
  src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 


Diff: https://reviews.apache.org/r/65393/diff/3/

Changes: https://reviews.apache.org/r/65393/diff/2-3/


Testing
-------

ran mesos-tests --docker flag.


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message