mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 65162: Removed some redundant `get` calls.
Date Mon, 12 Feb 2018 19:05:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65162/#review197287
-----------------------------------------------------------


Ship it!




I thought I'd finished reviewing because I reached the bottom of the page, but it's split
across 5 pages.

However, this was done automatically, and the first page of changes all appear sane. Moreover,
the chain passed the review bots, so I think I'm a ship-it.


src/linux/cgroups.cpp
Lines 2410-2419 (original), 2410-2418 (patched)
<https://reviews.apache.org/r/65162/#comment277413>

    It irks me that we have a C-style `(double)` cast here (and a `pid_t()` function-style
cast above, though perhaps that one irks me less). But it's not something to fix in this patch.


- Andrew Schwartzmeyer


On Feb. 12, 2018, 7:55 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65162/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2018, 7:55 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed some redundant `get` calls.
> 
> 
> Diffs
> -----
> 
>   src/appc/spec.cpp fc5e24ee5a459522a7a2dc52b4f168c4386b0642 
>   src/authentication/cram_md5/auxprop.cpp 8a20d5bd2d943faa10d2920f76756fb9527075d8 
>   src/cli/execute.cpp 729896a4021a3be6dfd41a5f6bc78872170fe68a 
>   src/common/command_utils.cpp c50be7608df3a7e0a6a9d0bb46525a3cbd025bee 
>   src/common/http.cpp 728fc554917ed031f9cb3d811fbbc064307b3e32 
>   src/common/parse.hpp 212d6406a16f5ffd0494197dc44271629dc5ba3b 
>   src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
>   src/common/recordio.hpp c58bb14866a3ec3841b09d2e96bb16af20a2e6fd 
>   src/credentials/credentials.hpp c790793c7ea5ed384bdb397bfc1592b8fd1ff327 
>   src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28 
>   src/docker/spec.cpp 538cf1883d0dbf953ab5017d9b7d54a68ee72c73 
>   src/executor/executor.cpp 945936883afba0b52c95242cd410c335424b5768 
>   src/files/files.cpp 324b4bcf0ef53931fa7ef9b7a891b160564705ff 
>   src/hook/manager.cpp c659de5418881a77d89e6c579152614c2b47592b 
>   src/internal/evolve.cpp 7758c9b93ad41b45b941c0de8c2b1008fbc4e50d 
>   src/launcher/executor.cpp 164ecc7ba51f75db6ec581aa4b135526c304dd00 
>   src/launcher/fetcher.cpp 7fc69fe22b362bf0d13d629829a2c6a9de4f1579 
>   src/linux/cgroups.cpp ed22c456a3d12b690efccca96c619267157ee6d7 
>   src/linux/fs.cpp 94e78df0336f63c58eb3d4da0d7fe45dfcb493c1 
>   src/linux/ns.cpp fc0e7e4543903788451c44858dd2705372946ae1 
>   src/local/local.cpp ba1bcf21df70bba520f3f9b671bb57d498335c44 
>   src/log/catchup.cpp 79cc18c4311d14c82801d856681171c5f1ce95c8 
>   src/log/consensus.cpp f766015fac44cce173ec7ef3f5dd3f0ac9e03ef5 
>   src/log/replica.cpp c86a609f7fc7fcfd42761180c464c383961a986e 
>   src/log/tool/benchmark.cpp b939e26aceafc47015f3f0a93c5ce6a1f8aca605 
>   src/log/tool/initialize.cpp c0f85439a87f939bad076733fbc9e12b60f5b8f9 
>   src/log/tool/read.cpp 50fb0209a67251eb6ae320f3cd6dcd7ba11bdd99 
>   src/master/allocator/mesos/hierarchical.cpp f33ff767dcb93556beb696c96f8cfc17baccb05e

>   src/master/contender/contender.cpp ea7453d1d4753a77c6161ec0b812bb0bf38483dd 
>   src/master/contender/zookeeper.cpp 64fbb3adbb0812f430fe152550a8a8707c0fed8f 
>   src/master/detector/detector.cpp 9d2e8c4d3fb342fe4ada01628b33b7c470ba63b6 
>   src/master/detector/zookeeper.cpp 1cab567615d756ebd1a40549718c47b642cf0eb8 
>   src/master/http.cpp 46f2872a17215464de2e4990e9cfcb3bff46812a 
>   src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9 
>   src/master/master.hpp b434d2398b8815811345b6586ca586d2025cb2a2 
>   src/master/master.cpp d7d22866f7a4eb87bd8949efafc97e828e7d4b94 
>   src/master/quota_handler.cpp 37d43e1d9473b750ffd76701472e7448aa61c8c3 
>   src/master/registrar.cpp aabce22e4b06826e4452c61c27ebdd702b1e47bc 
>   src/master/validation.cpp 42f767e4269abe3f160fc7d97eb4522d1bee8e95 
>   src/master/weights_handler.cpp 59104a85d2b74cf42461b02d85101c7c751f706c 
>   src/resource_provider/http_connection.hpp add5acc47aaf79b50ef9a7bd1e17ff0db5b95439

>   src/resource_provider/registrar.cpp 3e6b64bae1c56d3ca27edd0debac428b47f17d04 
>   src/sched/sched.cpp 613a33b7d3150ad851af674e989a84b3899f2d69 
>   src/scheduler/scheduler.cpp 07d2b37e0874edd27365719705272568d386323b 
>   src/slave/container_loggers/lib_logrotate.cpp bc13e6a52460d4607873c4b0022165038051bc51

>   src/slave/containerizer/containerizer.cpp fa1d24a56380dd34ed15d3d12e610dfcfe4c56d6

>   src/slave/containerizer/docker.cpp 7585178f34bdb782f0108d3ab94c23edfacc5564 
>   src/slave/containerizer/fetcher.cpp 8b26e882eced9478ffdc6b2dcbc0a5796c5c3ce2 
>   src/slave/containerizer/mesos/containerizer.cpp cd1e9ae8b8925cb97396dde22b6a3eb63ab65536

>   src/slave/containerizer/mesos/io/switchboard.cpp ba7740403cdb9c3a35ee366d09503807a5cea27a

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp fc763bd7834567882146ad25e0266b1183154dc3

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuacct.cpp ffa0d3b0e6f3d8a1f55c88d61f20cff426119e20

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 99e824ae5ccafbad5f404f48461783ff05b35646

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 896656987012b3ffe5008ce6873c9a5249c058de

>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 7f2708c1f19102ec0c68674af21100443c383b96

>   src/slave/containerizer/mesos/isolators/volume/image.cpp 8ca3d55d5792ed1cfc8e49df40587ac2abc83fec

>   src/slave/containerizer/mesos/launcher.cpp 0e37cd256563c8d6ca2d5bc522246f7ee10c337d

>   src/slave/containerizer/mesos/linux_launcher.cpp 1546b6b08626a7b4988c9d7fcaa2c25c0d8e97d9

>   src/slave/containerizer/mesos/provisioner/appc/cache.cpp 0cd444b93528545bd01e3b59ba77db2e3a341029

>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp d6cdc93128c3663fae3cdf77b9c5c373bc3d662d

>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 69faa03f306032447fa33ae2de8a55fee9c2ed41

>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp e1939a44eea1dc383bf6d618bdd155d76dab80a4

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 7b6ddb18b2d2917cc6763aed7f830534ce579cda

>   src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c 
>   src/slave/qos_controllers/load.cpp a241ef3a94cf35e53273a1e47f8ede589fd8b580 
>   src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5 
>   src/slave/validation.cpp 0c2ccda177734cf3c47c0346ed34d20d58e7d932 
>   src/state/in_memory.cpp f6852e041b64342e7755b00eed3dcb379f137d19 
>   src/state/leveldb.cpp 50d0c7c02f96dfd7987d6e31fafe40c91f651ae1 
>   src/state/log.cpp 48d10373c0552722b2f4228b49aab113270e07f8 
>   src/state/zookeeper.cpp f992fb948819b4f0b2c1fc65c7a5ebd2ca8f61e2 
>   src/tests/api_tests.cpp b042201bf07428bfc0007a713b98bf15d15470e1 
>   src/tests/cluster.cpp 19a41c7c1c303ad806daa4e5e3765a1e0b55933b 
>   src/tests/containerizer/cni_isolator_tests.cpp b8eb80fb671646cd7551f1ee6cfad6f4a81ebc8f

>   src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99

>   src/tests/containerizer/environment_secret_isolator_tests.cpp 9728587150064529eb94a48485ff3076f4464f33

>   src/tests/default_executor_tests.cpp cc97e0d1fea7f4d0bc544d850593d8d91921b552 
>   src/tests/environment.cpp 931e647c9531dc27c31a02b9e8aca15ef441a5b6 
>   src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d 
>   src/tests/master_maintenance_tests.cpp 2a0625873b4f9b6350c14e8304a8d6fbd6a45e6b 
>   src/tests/master_tests.cpp 76c86f8fb10339af263b6831ac1e58bc54f88c55 
>   src/tests/mesos.hpp c5593c25dde18c005f195a1885a8586bc72c849f 
>   src/tests/scheduler_http_api_tests.cpp 02cfe54375fdda6ae11cbe31f5c6eed920e5d7f6 
>   src/tests/slave_authorization_tests.cpp 2b3bbbcb7be5b2b9985bbe54bc72876e24b0ecbc 
>   src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 
>   src/uri/fetchers/copy.cpp 17f69bea4dd7040b70283dc6852c1bdc9ff27406 
>   src/uri/fetchers/curl.cpp e18573dacf3de1ef73911cf13b7c8afec5ea556e 
>   src/uri/fetchers/docker.cpp 91db13b29477df81bbbdee55672c743c77fb3935 
>   src/usage/usage.cpp 01c29f0934e0f740a8fdd5eadbf9a61837463a3a 
>   src/watcher/whitelist_watcher.cpp 3a556c556911a9c7c24539b9ecc031722372492a 
>   src/zookeeper/contender.cpp fa49647aa3591689a13dbfb55a41096cc3d002da 
> 
> 
> Diff: https://reviews.apache.org/r/65162/diff/4/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> These changes were made automatically with https://github.com/mesos/clang-tools-extra/pull/13
with only a few minor additions in surrounding code.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message