mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Coffler <j...@taltos.com>
Subject Re: Review Request 65508: Allow curl program to be properly executed on Windows platform.
Date Thu, 08 Feb 2018 23:08:51 GMT


> On Feb. 6, 2018, 7:12 p.m., Andrew Schwartzmeyer wrote:
> > Nit: Fix summary to be in past tense, and fix description to not be a copy of the
summary.
> 
> Jeff Coffler wrote:
>     This was a one-line commit, but I went ahead and added a second line. I'm not sure
why you said that the description shouldn't be a copy of the summary, it wasn't. Tooling problem
on your side, or just a mistake?
> 
> Andrew Schwartzmeyer wrote:
>     When you post a review with just a summary, the scripts copy the summary into the
description. This unfortunately carries through to the other side when the review is applied,
and then you have a weird commit. The (work-around?) is to not post one-line commit messages.
> 
> Jeff Coffler wrote:
>     That's odd. I think you mentioned this before, but I see one-line commits on Mesos,
like this:
>     
>     ```
>     commit 2ef5f4a
>     Author: Gilbert Song <songzihao1990@gmail.com>
>     Date:   Thu Feb 8 08:45:42 2018
>     
>         Added an image 1.3-1.5_v1_json_state_query_latency.png to docs/images.
>     
>     commit f7dbd29
>     Author: Michael Park <mpark@apache.org>
>     Date:   Wed Feb 7 20:28:42 2018
>     
>         Updated ReviewBot to use Ubuntu 16.04.
>     ```
>     
>     Am I doing something wrong. Do I need something "funny" in the description (like
a "." or something) if it's one line?

Talked F2F with Andy. This is a tooling issue. One-line commits are possible, if after rbt,
the copy of the one-line commit is removed from the "Description" field.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65508/#review196911
-----------------------------------------------------------


On Feb. 5, 2018, 6:12 p.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65508/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2018, 6:12 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Bugs: MESOS-6715
>     https://issues.apache.org/jira/browse/MESOS-6715
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow curl program to be properly executed on Windows platform.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/curl.cpp f34daf2bc1f3fef74548e04ad332e3a627636bfd 
> 
> 
> Diff: https://reviews.apache.org/r/65508/diff/1/
> 
> 
> Testing
> -------
> 
> Full build, unit tests on both Linux and Windows platform.
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message