mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 65469: Windows: Updated `internal::process:createChildProcess`.
Date Thu, 08 Feb 2018 19:50:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65469/
-----------------------------------------------------------

(Updated Feb. 8, 2018, 11:50 a.m.)


Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.


Changes
-------

Pretty much a new commit.


Summary (updated)
-----------------

Windows: Updated `internal::process:createChildProcess`.


Bugs: MESOS-8512
    https://issues.apache.org/jira/browse/MESOS-8512


Repository: mesos


Description (updated)
-------

The interface of `internal::windows:create_process` was changed to
accept a `std::array<os::WindowsFD, 3>` instead of a `std::tuple`.

Furthermore, the error handling in `subprocess` was incorrect. We only
need to check the success of `createChildProcess`; we do not need to
check if `pid == -1` on Windows. We also now return the actual error
from `create_process` if it errored, instead of the whole
`Try<process_data>`.

The TODO about closing the child-ends of the file descriptors was
resolved. We now close these in `createChildProcess`, immediately after
`create_process`. This means we only have to do it once.


Diffs (updated)
-----

  3rdparty/libprocess/src/subprocess.cpp 785e2e1083d115d25fffde2df74ed8bc1726511c 
  3rdparty/libprocess/src/subprocess_windows.hpp 0183bb451f68528acf31ed97754320c64f35102b



Diff: https://reviews.apache.org/r/65469/diff/2/

Changes: https://reviews.apache.org/r/65469/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message