mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.
Date Wed, 07 Feb 2018 19:27:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65551/#review197021
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65548', '65549', '65550', '65551']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65551

Relevant logs:

- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65551/logs/mesos-tests-cmake-stdout.log):

```
         D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(414): warning C4267: 'argument': conversion
from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(415): warning C4267: 'argument': conversion
from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(437): warning C4267: 'argument': conversion
from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(438): warning C4267: 'argument': conversion
from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(460): warning C4267: 'argument': conversion
from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(461): warning C4267: 'argument': conversion
from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(500): warning C4267: 'argument': conversion
from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(501): warning C4267: 'argument': conversion
from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_state_LogState.cpp(70): warning
C4244: 'initializing': conversion from 'jlong' to 'long', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_state_Variable.cpp(44): warning
C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_state_Variable.cpp(45): warning
C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(95): warning C4267: '=': conversion from 'size_t'
to 'jint', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(463): warning C4244: 'initializing': conversion
from 'jchar' to 'char', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(493): warning C4244: 'initializing': conversion
from 'jlong' to 'long', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(654): warning C4244: 'initializing': conversion
from 'jchar' to 'char', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(693): warning C4244: 'initializing': conversion
from 'jlong' to 'long', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(770): warning C4244: 'initializing': conversion
from 'jchar' to 'char', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(809): warning C4244: 'initializing': conversion
from 'jlong' to 'long', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]


       "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\java\mesos-java.vcxproj" (default target) (13) ->
       (ClCompile target) -> 
         D:\DCOS\mesos\mesos\include\mesos/v1/scheduler/scheduler.hpp(45): error C2679: binary
'<<': no operator found which takes a right-hand operand of type 'const mesos::v1::TaskStatus'
(or there is no acceptable conversion) (compiling source file D:\DCOS\mesos\mesos\src\java\jni\convert.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]

    214 Warning(s)
    1 Error(s)

Time Elapsed 00:07:02.04
```

- Mesos Reviewbot Windows


On Feb. 7, 2018, 7:05 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65551/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2018, 7:05 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8468
>     https://issues.apache.org/jira/browse/MESOS-8468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The default executor would be completely shutdown on a
> `LAUNCH_NESTED_CONTAINER` failure.
> 
> This patch makes it kill the affected task group instead of shutting
> down and killing all task groups.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea 
> 
> 
> Diff: https://reviews.apache.org/r/65551/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo make check` on GNU/Linux
> 
> Regression test on https://reviews.apache.org/r/65552/
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message