> On Feb. 6, 2018, 10:54 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/include/process/gtest.hpp
> > Lines 37 (patched)
> > <https://reviews.apache.org/r/65201/diff/7/?file=1953021#file1953021line37>
> >
> > I'd suggest to move this to an extra header file, e.g., `process/tests/constants.hpp`.
We could then include that header file here.
> >
> > Let's also rename the constant to `TEST_AWAIT_TIMEOUT` as `DEFAULT` is inconsequential.
Do you mean in `3rdparty/libprocess/include/process/tests` or in `3rdparty/libprocess/src/tests`?
> On Feb. 6, 2018, 10:54 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/src/gtest.cpp
> > Lines 1-23 (patched)
> > <https://reviews.apache.org/r/65201/diff/7/?file=1953023#file1953023line1>
> >
> > Let's move this to its own file, e.g., `process/tests/constants.cpp`. This implementation
file could always include its header file without issues.
All the files that are currently present in `process/tests` are exclusively built into the
test suite. I think that it would be confusing to add a file there that is actually part of
`libprocess.so`.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65201/#review196876
-----------------------------------------------------------
On Jan. 23, 2018, 9:57 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65201/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2018, 9:57 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Gaston Kleiman.
>
>
> Bugs: MESOS-7016
> https://issues.apache.org/jira/browse/MESOS-7016
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a global `DEFAULT_TEST_TIMEOUT` variable that applications
> can use to globally tune the default timeout in the `AWAIT_READY`
> family of test macros. The default remains 15sec.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 3071b7ce2b82a4ce0ea62e4d2b3518a6f5114803
> 3rdparty/libprocess/include/process/gtest.hpp eee726653d52af2e4a148819e420ebd22e5123a9
> 3rdparty/libprocess/src/CMakeLists.txt f002c157dc2ca64da66bc4e61f5095f2b533ae1f
> 3rdparty/libprocess/src/gtest.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65201/diff/7/
>
>
> Testing
> -------
>
> make check (Fedora 27).
>
>
> Thanks,
>
> James Peach
>
>
|