mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 65529: Added --clean flag to bootstrap script for Mesos CLI.
Date Wed, 07 Feb 2018 15:24:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65529/
-----------------------------------------------------------

(Updated Feb. 7, 2018, 3:24 p.m.)


Review request for mesos and Kevin Klues.


Changes
-------

Used Python to make the bash script cross-platform.


Bugs: MESOS-8240
    https://issues.apache.org/jira/browse/MESOS-8240


Repository: mesos


Description
-------

Without it, the bootstrap script compares the modification date
of the virtual environment compared to the pip-requirements
and bootstrap script. If the virtualenv is newer, the bootstrap
script will stop instead of building the environment again.


Diffs (updated)
-----

  src/python/cli_new/bootstrap c84e549e59bc7a07b5b70c24c63bc0c16881e442 


Diff: https://reviews.apache.org/r/65529/diff/2/

Changes: https://reviews.apache.org/r/65529/diff/1-2/


Testing
-------

Run bootstrap script three times. With no `.virtualenv`:
```
$ ./bootstrap
```
Creates the virtual environment.
```
$ ./bootstrap
The virtual environment is more recent than its dependencies, no need
to rebuild it. Use 'bootstrap --clean' to rebuild the virtualenv
without comparing its last modification date with its dependencies.
$ ./bootstrap --clean
```
The virtual environment will then be rebuilt again with this third command.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message