From reviews-return-72658-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Wed Jan 31 02:15:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 8B0C818061A for ; Wed, 31 Jan 2018 02:15:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7AD3A160C54; Wed, 31 Jan 2018 01:15:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C377E160C53 for ; Wed, 31 Jan 2018 02:15:04 +0100 (CET) Received: (qmail 81438 invoked by uid 500); 31 Jan 2018 01:15:04 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 81425 invoked by uid 99); 31 Jan 2018 01:15:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jan 2018 01:15:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D13F918AF6C; Wed, 31 Jan 2018 01:15:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.39 X-Spam-Level: ** X-Spam-Status: No, score=2.39 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id hz5e06AjPRP1; Wed, 31 Jan 2018 01:15:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BEB9360EB7; Wed, 31 Jan 2018 01:15:00 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2BD28E00B0; Wed, 31 Jan 2018 01:15:00 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0002AC4025B; Wed, 31 Jan 2018 01:14:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7791460432928071849==" MIME-Version: 1.0 Subject: Re: Review Request 65382: Reaped Docker executor only when it can be connected. From: Qian Zhang To: Vinod Kone Cc: Qian Zhang , mesos Date: Wed, 31 Jan 2018 01:14:59 -0000 Message-ID: <20180131011459.30253.36288@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65382/ X-Sender: Qian Zhang References: <20180130222508.30253.99711@reviews-vm2.apache.org> In-Reply-To: <20180130222508.30253.99711@reviews-vm2.apache.org> Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============7791460432928071849== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 31, 2018, 6:25 a.m., Vinod Kone wrote: > > src/slave/containerizer/docker.cpp > > Lines 979 (patched) > > > > > > Do we return a "failed" container termination here? AFAICT, we return `None` on `wait` in this case? Right, we return `None` in `DockerContainerizerProcess::wait`, I am not sure why it was a `failed 'ContainerTermination'`, let me correct it. > On Jan. 31, 2018, 6:25 a.m., Vinod Kone wrote: > > src/slave/containerizer/docker.cpp > > Lines 1047 (patched) > > > > > > s/reboots/reboots or restarts/ ? I think they are same, right? The point here is the agent host is rebooted rather than just agent process is restarted which will not cause the executor pid reused by an irrelevant process. > On Jan. 31, 2018, 6:25 a.m., Vinod Kone wrote: > > src/slave/containerizer/docker.cpp > > Lines 1052-1054 (patched) > > > > > > LOG(WARNING) << "Failed to connect to executor '" << executor.id > > << "' of framework " << framework.id > > > > Can we log the SocketError here as well? Sure. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65382/#review196536 ----------------------------------------------------------- On Jan. 31, 2018, 9:14 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65382/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2018, 9:14 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-8125 > https://issues.apache.org/jira/browse/MESOS-8125 > > > Repository: mesos > > > Description > ------- > > Reaped Docker executor only when it can be connected. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp f1d7d3e6afa119a6a24b054dcaa5ee68dbea965d > > > Diff: https://reviews.apache.org/r/65382/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > > --===============7791460432928071849==--