From reviews-return-72559-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Mon Jan 29 19:21:55 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 6947C180654 for ; Mon, 29 Jan 2018 19:21:55 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 58ADD160C31; Mon, 29 Jan 2018 18:21:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A0D66160C2F for ; Mon, 29 Jan 2018 19:21:54 +0100 (CET) Received: (qmail 27941 invoked by uid 500); 29 Jan 2018 18:21:53 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 27930 invoked by uid 99); 29 Jan 2018 18:21:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jan 2018 18:21:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B7078CD651; Mon, 29 Jan 2018 18:21:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.878 X-Spam-Level: * X-Spam-Status: No, score=1.878 tagged_above=-999 required=6.31 tests=[FORGED_HOTMAIL_RCVD2=1.187, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id iCsiEjXtrID3; Mon, 29 Jan 2018 18:21:52 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3698A5F58D; Mon, 29 Jan 2018 18:21:51 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 86106E0115; Mon, 29 Jan 2018 18:21:50 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 5D112C40098; Mon, 29 Jan 2018 18:21:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4393536596636895945==" MIME-Version: 1.0 Subject: Review Request 65396: Moved docker command check code inside health check library. From: Akash Gupta To: Alexander Rukletsov , Andrew Schwartzmeyer , Gaston Kleiman Cc: Akash Gupta , mesos Date: Mon, 29 Jan 2018 18:21:50 -0000 Message-ID: <20180129182150.29449.95365@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Akash Gupta X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65396/ X-Sender: Akash Gupta Reply-To: Akash Gupta X-ReviewRequest-Repository: mesos --===============4393536596636895945== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65396/ ----------------------------------------------------------- Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman. Bugs: MESOS-8498 https://issues.apache.org/jira/browse/MESOS-8498 Repository: mesos Description ------- Now with the health check library refactor, the wrapping of `docker exec` for docker command health checks can be easily moved inside the library. Diffs ----- src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a Diff: https://reviews.apache.org/r/65396/diff/1/ Testing ------- make check Thanks, Akash Gupta --===============4393536596636895945==--