From reviews-return-72422-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Thu Jan 25 13:06:54 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id A75EC180651 for ; Thu, 25 Jan 2018 13:06:54 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 973CF160C3D; Thu, 25 Jan 2018 12:06:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DC76A160C13 for ; Thu, 25 Jan 2018 13:06:53 +0100 (CET) Received: (qmail 93189 invoked by uid 500); 25 Jan 2018 12:06:53 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 93173 invoked by uid 99); 25 Jan 2018 12:06:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jan 2018 12:06:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id BCAA1C0EB4; Thu, 25 Jan 2018 12:06:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.54 X-Spam-Level: ** X-Spam-Status: No, score=2.54 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 36Tn5IN-o3lw; Thu, 25 Jan 2018 12:06:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 41E865FBFC; Thu, 25 Jan 2018 12:06:48 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8975CE01A8; Thu, 25 Jan 2018 12:06:47 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E9018C4025B; Thu, 25 Jan 2018 12:06:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3581766930432861399==" MIME-Version: 1.0 Subject: Re: Review Request 65246: Added download button for master and agent logs in Web UI. From: Mesos Reviewbot Windows To: Benjamin Mahler , Vinod Kone Cc: Mesos Reviewbot Windows , Armand Grillet , mesos Date: Thu, 25 Jan 2018 12:06:45 -0000 Message-ID: <20180125120645.814.33978@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65246/ X-Sender: Mesos Reviewbot Windows References: <20180125104404.885.19837@reviews-vm2.apache.org> In-Reply-To: <20180125104404.885.19837@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============3581766930432861399== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65246/#review196237 ----------------------------------------------------------- PASS: Mesos patch 65246 was successfully built and tested. Reviews applied: `['65246']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65246 - Mesos Reviewbot Windows On Jan. 25, 2018, 2:44 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65246/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2018, 2:44 a.m.) > > > Review request for mesos, Benjamin Mahler and Vinod Kone. > > > Bugs: MESOS-8454 > https://issues.apache.org/jira/browse/MESOS-8454 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/webui/master/static/agent.html 908d01d1d28f2a4fc595b581fa16515c5be1410a > src/webui/master/static/home.html df3eef61eb9564dbdfc3d138ecfd18e85f747f11 > src/webui/master/static/js/controllers.js 59665869dbea77c00740e42f2590473181dfe2fe > > > Diff: https://reviews.apache.org/r/65246/diff/2/ > > > Testing > ------- > > Created an High Availability Mode Mesos cluster locally: > > ``` > $ zkServer start > $ bash mesos-master.sh --port='5061' --zk='zk://127.0.0.1:2181/mesos' --work_dir='/tmp/master1' --quorum=1 --webui_dir='/Users/Armand/Code/apache-mesos/src/webui' --log_dir='/tmp/master1-log' > $ bash mesos-master.sh --port='5062' --zk='zk://127.0.0.1:2181/mesos' --work_dir='/tmp/master2' --quorum=1 --webui_dir='/Users/Armand/Code/apache-mesos/src/webui' --log_dir='/tmp/master2-log' > $ bash mesos-agent.sh --port='5051' --master='zk://127.0.0.1:2181/mesos' --work_dir='/tmp/agent1' --log_dir='/tmp/agent1-log' > ``` > Tested the download and streaming features on the home and agents Web UI endpoints, from both `http://localhost:5061/` and `http://localhost:5062/`. > > New UI (rev. 1): > ![New logs button](https://i.imgur.com/vo9mXT6.png) > > New UI (rev. 2): > ![New logs button](https://i.imgur.com/63BAvpr.png) > > > Thanks, > > Armand Grillet > > --===============3581766930432861399==--