From reviews-return-71962-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Tue Jan 16 20:24:08 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 5AA8318065B for ; Tue, 16 Jan 2018 20:24:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4AD2E160C34; Tue, 16 Jan 2018 19:24:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9168E160C1D for ; Tue, 16 Jan 2018 20:24:07 +0100 (CET) Received: (qmail 26837 invoked by uid 500); 16 Jan 2018 19:24:06 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 26825 invoked by uid 99); 16 Jan 2018 19:24:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2018 19:24:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 109B4180337; Tue, 16 Jan 2018 19:24:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.74 X-Spam-Level: *** X-Spam-Status: No, score=3.74 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id QKws_zPsgnpz; Tue, 16 Jan 2018 19:24:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 01AE05F340; Tue, 16 Jan 2018 19:24:05 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9D279E01A7; Tue, 16 Jan 2018 19:24:04 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 11437C40A32; Tue, 16 Jan 2018 19:24:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0050381012018461841==" MIME-Version: 1.0 Subject: Re: Review Request 65180: Removed a comment in io switchboard. From: Kevin Klues To: Kevin Klues , Alexander Rukletsov Cc: Andrei Budnik , mesos Date: Tue, 16 Jan 2018 19:24:02 -0000 Message-ID: <20180116192402.41739.34745@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kevin Klues X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65180/ X-Sender: Kevin Klues References: <20180116190514.41739.30369@reviews-vm2.apache.org> In-Reply-To: <20180116190514.41739.30369@reviews-vm2.apache.org> Reply-To: Kevin Klues X-ReviewRequest-Repository: mesos --===============0050381012018461841== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65180/#review195486 ----------------------------------------------------------- src/slave/containerizer/mesos/io/switchboard.cpp Lines 666-669 (original) Does 4069e1c424 address making sure the IO-Switchboard allows reconnects after agent restarts? - Kevin Klues On Jan. 16, 2018, 7:05 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65180/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2018, 7:05 p.m.) > > > Review request for mesos, Alexander Rukletsov and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > The comment is incorrect since the commit 4069e1c424 has been landed. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp 4ef640616d69b91c225206444737a40f9571da55 > > > Diff: https://reviews.apache.org/r/65180/diff/1/ > > > Testing > ------- > > None: not a functional change. > > > Thanks, > > Andrei Budnik > > --===============0050381012018461841==--