From reviews-return-71928-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Tue Jan 16 02:50:48 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id C7284180657 for ; Tue, 16 Jan 2018 02:50:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B71EA160C45; Tue, 16 Jan 2018 01:50:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 09769160C31 for ; Tue, 16 Jan 2018 02:50:47 +0100 (CET) Received: (qmail 34120 invoked by uid 500); 16 Jan 2018 01:50:47 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 34109 invoked by uid 99); 16 Jan 2018 01:50:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2018 01:50:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 84C37C83CF; Tue, 16 Jan 2018 01:50:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.99 X-Spam-Level: *** X-Spam-Status: No, score=3.99 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id km5t-MBK1XWt; Tue, 16 Jan 2018 01:50:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 783175F2FD; Tue, 16 Jan 2018 01:50:45 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5C0EEE01D8; Tue, 16 Jan 2018 01:50:44 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DC837C40440; Tue, 16 Jan 2018 01:50:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2864103192089073534==" MIME-Version: 1.0 Subject: Re: Review Request 65105: Fixed a couple of minor network/ports isolator issues. From: Qian Zhang To: Qian Zhang , Jiang Yan Xu Cc: James Peach , mesos Date: Tue, 16 Jan 2018 01:50:41 -0000 Message-ID: <20180116015041.16736.40094@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65105/ X-Sender: Qian Zhang X-ReviewBoard-ShipIt: 1 References: <20180112011442.41446.13513@reviews-vm2.apache.org> In-Reply-To: <20180112011442.41446.13513@reviews-vm2.apache.org> Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============2864103192089073534== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65105/#review195441 ----------------------------------------------------------- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 528-530 (patched) Can we keep these codes in 2 lines? And I do not think we need to call `stringify()` for `containerId` here. ``` LOG(INFO) << "Updated ports to " << intervalSetToRanges(info->ports.get()) << " for container " << containerId; ``` - Qian Zhang On Jan. 12, 2018, 9:14 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65105/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 9:14 a.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Added a log message (similar to the one in the `cgroup/cpu` isolator > to track then the resouces for a container are updated. > > Hoisted a `CHECK` so that it happens before accessing the protobuf > field it is protecting. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/ports.cpp 7d5ff4f6d917352abd9ac0158a56eae7911aff0f > > > Diff: https://reviews.apache.org/r/65105/diff/1/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > > --===============2864103192089073534==--