From reviews-return-71782-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Fri Jan 12 05:53:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 92F73180656 for ; Fri, 12 Jan 2018 05:53:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 829D6160C13; Fri, 12 Jan 2018 04:53:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CB846160C41 for ; Fri, 12 Jan 2018 05:53:03 +0100 (CET) Received: (qmail 49448 invoked by uid 500); 12 Jan 2018 04:53:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 49319 invoked by uid 99); 12 Jan 2018 04:53:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jan 2018 04:53:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 03BA41A0FBD; Fri, 12 Jan 2018 04:53:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.29 X-Spam-Level: ** X-Spam-Status: No, score=2.29 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id uZNCPYnzIfLn; Fri, 12 Jan 2018 04:53:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id DA6105F576; Fri, 12 Jan 2018 04:52:59 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 30F0BE026E; Fri, 12 Jan 2018 04:52:59 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id EE14CC400F6; Fri, 12 Jan 2018 04:52:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7603562261344881738==" MIME-Version: 1.0 Subject: Re: Review Request 65114: Updated C++ Style Guide. From: Mesos Reviewbot Windows To: Jie Yu , Benjamin Mahler , Joseph Wu , Greg Mann Cc: Mesos Reviewbot Windows , Andrew Schwartzmeyer , mesos Date: Fri, 12 Jan 2018 04:52:54 -0000 Message-ID: <20180112045254.41418.28026@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65114/ X-Sender: Mesos Reviewbot Windows References: <20180112020703.41446.57097@reviews-vm2.apache.org> In-Reply-To: <20180112020703.41446.57097@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============7603562261344881738== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65114/#review195291 ----------------------------------------------------------- PASS: Mesos patch 65114 was successfully built and tested. Reviews applied: `['65113', '65114']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65114 - Mesos Reviewbot Windows On Jan. 12, 2018, 2:07 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65114/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 2:07 a.m.) > > > Review request for mesos, Benjamin Mahler, Greg Mann, Jie Yu, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Added three missing style notes: > > * Use of `::` for global namespace > * Put `template ` on own line > * Prefer `->foo()` to `.get().foo()` > > > Diffs > ----- > > docs/c++-style-guide.md ef80c868fd3f366c998bc33c9f8a664dc35b0336 > > > Diff: https://reviews.apache.org/r/65114/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > > --===============7603562261344881738==--