From reviews-return-71569-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Tue Jan 9 21:01:39 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 7B1CA180718 for ; Tue, 9 Jan 2018 21:01:39 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6DAAD160C2D; Tue, 9 Jan 2018 20:01:39 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B4C78160C17 for ; Tue, 9 Jan 2018 21:01:38 +0100 (CET) Received: (qmail 34211 invoked by uid 500); 9 Jan 2018 20:01:37 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 34200 invoked by uid 99); 9 Jan 2018 20:01:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jan 2018 20:01:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1BCD1C433D; Tue, 9 Jan 2018 20:01:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.54 X-Spam-Level: ** X-Spam-Status: No, score=2.54 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 4IRIinpQ5HMr; Tue, 9 Jan 2018 20:01:33 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BD6655F39D; Tue, 9 Jan 2018 20:01:32 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 63991E00A3; Tue, 9 Jan 2018 20:01:32 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 202EEC400C2; Tue, 9 Jan 2018 20:01:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0968154387810966903==" MIME-Version: 1.0 Subject: Re: Review Request 64743: Enabled function sections. From: Mesos Reviewbot Windows To: Benjamin Bannier , Andrew Schwartzmeyer Cc: Mesos Reviewbot Windows , James Peach , mesos Date: Tue, 09 Jan 2018 20:01:29 -0000 Message-ID: <20180109200129.56467.78000@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/64743/ X-Sender: Mesos Reviewbot Windows References: <20180109184009.56467.38572@reviews-vm2.apache.org> In-Reply-To: <20180109184009.56467.38572@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============0968154387810966903== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64743/#review195064 ----------------------------------------------------------- PASS: Mesos patch 64743 was successfully built and tested. Reviews applied: `['64743']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64743 - Mesos Reviewbot Windows On Jan. 9, 2018, 6:40 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64743/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2018, 6:40 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. > > > Bugs: MESOS-8348 > https://issues.apache.org/jira/browse/MESOS-8348 > > > Repository: mesos > > > Description > ------- > > If we tell the compiler to place each function in a separate > section, this allows the linker to garbage collect unused > sections. This significantly decreases the size of the final > build artifacts and provides some modest improvements in build > times. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 0ae05047265e33aefab6eef67a4243b6b00f0318 > configure.ac b6eb98bfe5539c68a416831c36c182ee907d9421 > docs/configuration/autotools.md c6ac196fd5023391143313821185cac096b41a2b > docs/configuration/cmake.md 5364b1e0398e8e774c89993bd7404c32abe3bedc > > > Diff: https://reviews.apache.org/r/64743/diff/6/ > > > Testing > ------- > > make check > > > Thanks, > > James Peach > > --===============0968154387810966903==--