From reviews-return-71484-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Mon Jan 8 22:35:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 8BB70180607 for ; Mon, 8 Jan 2018 22:35:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7B537160C2C; Mon, 8 Jan 2018 21:35:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C0D70160C29 for ; Mon, 8 Jan 2018 22:35:03 +0100 (CET) Received: (qmail 14398 invoked by uid 500); 8 Jan 2018 21:35:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 14386 invoked by uid 99); 8 Jan 2018 21:35:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jan 2018 21:35:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4B25CC4012; Mon, 8 Jan 2018 21:35:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.789 X-Spam-Level: ** X-Spam-Status: No, score=2.789 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 8CmSc246COUv; Mon, 8 Jan 2018 21:35:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 408035F3DF; Mon, 8 Jan 2018 21:35:00 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 85949E023C; Mon, 8 Jan 2018 21:34:59 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 4D0E6C40362; Mon, 8 Jan 2018 21:34:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9002140624739570640==" MIME-Version: 1.0 Subject: Re: Review Request 65016: Use flag class to perform example framework flag validation. From: Gaston Kleiman To: Gaston Kleiman Cc: Benjamin Bannier , mesos Date: Mon, 08 Jan 2018 21:34:56 -0000 Message-ID: <20180108213456.8229.68120@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gaston Kleiman X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65016/ X-Sender: Gaston Kleiman X-ReviewBoard-ShipIt: 1 References: <20180108100539.5596.93280@reviews-vm2.apache.org> In-Reply-To: <20180108100539.5596.93280@reviews-vm2.apache.org> Reply-To: Gaston Kleiman X-ReviewRequest-Repository: mesos --===============9002140624739570640== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65016/#review194981 ----------------------------------------------------------- Ship it! Thanks a lot for the cleanup! - Gaston Kleiman On Jan. 8, 2018, 2:05 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65016/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2018, 2:05 a.m.) > > > Review request for mesos and Gaston Kleiman. > > > Repository: mesos > > > Description > ------- > > This replaces ad hoc validation checking e.g., whether required > example framework flags are present or contain permissable values with > delegation to in-built or injected validation functions in the > 'FlagsBase'. Some validation of flag dependencies remains. > > > Diffs > ----- > > src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 > src/examples/load_generator_framework.cpp 42867992eba8699cab5b70c62a24b87446139406 > src/examples/no_executor_framework.cpp 972ef777cec07d1030af208daef69ebe606d071e > src/examples/persistent_volume_framework.cpp 71db39d7743d31ea34c2aed579d7a1ef2ed95687 > src/examples/test_framework.cpp acf1faf1523c8c03483dfafbc8f8e245322527e4 > src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a > > > Diff: https://reviews.apache.org/r/65016/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > > --===============9002140624739570640==--