mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 65382: Reaped Docker executor only when it can be connected.
Date Wed, 31 Jan 2018 01:14:59 GMT


> On Jan. 31, 2018, 6:25 a.m., Vinod Kone wrote:
> > src/slave/containerizer/docker.cpp
> > Lines 979 (patched)
> > <https://reviews.apache.org/r/65382/diff/2/?file=1950458#file1950458line979>
> >
> >     Do we return a "failed" container termination here? AFAICT, we return `None`
on `wait` in this case?

Right, we return `None` in `DockerContainerizerProcess::wait`, I am not sure why it was a
`failed 'ContainerTermination'`, let me correct it.


> On Jan. 31, 2018, 6:25 a.m., Vinod Kone wrote:
> > src/slave/containerizer/docker.cpp
> > Lines 1047 (patched)
> > <https://reviews.apache.org/r/65382/diff/2/?file=1950458#file1950458line1047>
> >
> >     s/reboots/reboots or restarts/ ?

I think they are same, right? The point here is the agent host is rebooted rather than just
agent process is restarted which will not cause the executor pid reused by an irrelevant process.


> On Jan. 31, 2018, 6:25 a.m., Vinod Kone wrote:
> > src/slave/containerizer/docker.cpp
> > Lines 1052-1054 (patched)
> > <https://reviews.apache.org/r/65382/diff/2/?file=1950458#file1950458line1052>
> >
> >     LOG(WARNING) << "Failed to connect to executor '" << executor.id
> >                  << "' of framework " << framework.id
> >                  
> >     Can we log the SocketError here as well?

Sure.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65382/#review196536
-----------------------------------------------------------


On Jan. 31, 2018, 9:14 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65382/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2018, 9:14 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8125
>     https://issues.apache.org/jira/browse/MESOS-8125
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Reaped Docker executor only when it can be connected.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp f1d7d3e6afa119a6a24b054dcaa5ee68dbea965d 
> 
> 
> Diff: https://reviews.apache.org/r/65382/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message