mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once.
Date Fri, 26 Jan 2018 14:17:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65350/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.


Bugs: MESOS-8489
    https://issues.apache.org/jira/browse/MESOS-8489


Repository: mesos


Description
-------

This patch modifies `cgroup::prepare` function to save the results of
a test for a nested cgroups support in a hashmap to reuse it in the
future.

Besides optimization, this patch fixes flaky
`LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags` test. There
was a race condition between two starting agents, where the first
agent could detect `test` orphaned container while iterating over
`/sys/fs/cgroup/freezer/mesos/` cgroup, because the second agent
is calling `cgroup::prepare` during its initialization. This patch
fixes the test, because it won't create a `test` cgroup in
`cgroups::prepare` as this test has already been passed during the
initialization of the first agent and the result is stored in hashmap.


Diffs
-----

  src/linux/cgroups.cpp cdd0f40ec5748b909e529f21b15523122bf90d41 


Diff: https://reviews.apache.org/r/65350/diff/1/


Testing
-------

sudo make check (Fedora 25)
internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message