mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 65246: Added download button for master and agent logs in Web UI.
Date Thu, 25 Jan 2018 10:44:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65246/
-----------------------------------------------------------

(Updated Jan. 25, 2018, 10:44 a.m.)


Review request for mesos, Benjamin Mahler and Vinod Kone.


Changes
-------

UI updated following issue created for /r/65245


Bugs: MESOS-8454
    https://issues.apache.org/jira/browse/MESOS-8454


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/webui/master/static/agent.html 908d01d1d28f2a4fc595b581fa16515c5be1410a 
  src/webui/master/static/home.html df3eef61eb9564dbdfc3d138ecfd18e85f747f11 
  src/webui/master/static/js/controllers.js 59665869dbea77c00740e42f2590473181dfe2fe 


Diff: https://reviews.apache.org/r/65246/diff/2/

Changes: https://reviews.apache.org/r/65246/diff/1-2/


Testing (updated)
-------

Created an High Availability Mode Mesos cluster locally:

```
$ zkServer start
$ bash mesos-master.sh --port='5061' --zk='zk://127.0.0.1:2181/mesos' --work_dir='/tmp/master1'
--quorum=1 --webui_dir='/Users/Armand/Code/apache-mesos/src/webui' --log_dir='/tmp/master1-log'
$ bash mesos-master.sh --port='5062' --zk='zk://127.0.0.1:2181/mesos' --work_dir='/tmp/master2'
--quorum=1 --webui_dir='/Users/Armand/Code/apache-mesos/src/webui' --log_dir='/tmp/master2-log'
$ bash mesos-agent.sh --port='5051' --master='zk://127.0.0.1:2181/mesos' --work_dir='/tmp/agent1'
--log_dir='/tmp/agent1-log'
```
Tested the download and streaming features on the home and agents Web UI endpoints, from both
`http://localhost:5061/` and `http://localhost:5062/`.

New UI (rev. 1):
![New logs button](https://i.imgur.com/vo9mXT6.png)

New UI (rev. 2):
![New logs button](https://i.imgur.com/63BAvpr.png)


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message