mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.
Date Tue, 23 Jan 2018 21:57:07 GMT


> On Jan. 22, 2018, 9:08 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/Makefile.am
> > Lines 200 (patched)
> > <https://reviews.apache.org/r/65201/diff/2/?file=1941379#file1941379line202>
> >
> >     I don't really like adding this testing tool to `libprocess`. Could you introduce
some convenience library here the mesos and libprocess tests could link to (similar for cmake).

Removed the includes so that we can't accidentally introduce gtest binary dependencies.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65201/#review195938
-----------------------------------------------------------


On Jan. 17, 2018, 11:54 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65201/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2018, 11:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Gaston Kleiman.
> 
> 
> Bugs: MESOS-7016
>     https://issues.apache.org/jira/browse/MESOS-7016
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a global `DEFAULT_TEST_TIMEOUT` variable that applications
> can use to globally tune the default timeout in the `AWAIT_READY`
> family of test macros. The default remains 15sec.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am ba9e78148932304ce1961b88e5f97180abd35586 
>   3rdparty/libprocess/include/process/gtest.hpp eee726653d52af2e4a148819e420ebd22e5123a9

>   3rdparty/libprocess/src/gtest.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65201/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27).
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message