mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.
Date Tue, 23 Jan 2018 15:12:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65261/#review196009
-----------------------------------------------------------



Great idea, Andrei: clever yet clear and clean. We can ship this once you address the feedback.


src/slave/containerizer/mesos/io/switchboard.cpp
Lines 842-843 (original), 845-852 (patched)
<https://reviews.apache.org/r/65261/#comment275519>

    If you add an override for  `getContainerIOSwitchboardSocketTempPath()` that takes same
arguments as  `getContainerIOSwitchboardSocketPath()`, this snippet will reduce to a tertiary
operator and will become more readable.



src/slave/containerizer/mesos/io/switchboard.cpp
Lines 1057 (patched)
<https://reviews.apache.org/r/65261/#comment275521>

    change "temporary" to a more specific word, see above.



src/slave/containerizer/mesos/io/switchboard.cpp
Lines 1058 (patched)
<https://reviews.apache.org/r/65261/#comment275520>

    s/then rename it with the original path./and rename it it after `listen()` has been called./



src/slave/containerizer/mesos/paths.hpp
Lines 147-149 (patched)
<https://reviews.apache.org/r/65261/#comment275517>

    Let's find a more descriptive word for this, "temp" can mean anything. We want to say,
that this is a path that exists before the socket is being listend on, or, in other words,
fully initialized.
    
    How about "prefatory" or "preparatory". Maybe "prep" is sufficient. Can you please consult
a native English speaker?


- Alexander Rukletsov


On Jan. 22, 2018, 1 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65261/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2018, 1 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-7742
>     https://issues.apache.org/jira/browse/MESOS-7742
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Once IOSwitchboard's unix socket appears in the file system, the agent
> can try to connect to it. If the agent attempts to connect to the
> socket before `listen` has been called, then it gets connection refused
> error. To address this, create a unix socket using a temporary name,
> then initialize it, then rename the socket with the original path.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 45b615be60af9af839309011eea85912c01ff451

>   src/slave/containerizer/mesos/paths.hpp 65830a153f765c74bb0399bca9b2941390eeb531 
>   src/slave/containerizer/mesos/paths.cpp 0df4cf5f50aee94a2758ce885389fb488a85fdbd 
> 
> 
> Diff: https://reviews.apache.org/r/65261/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message