mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.
Date Mon, 22 Jan 2018 09:22:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65189/#review195884
-----------------------------------------------------------




support/apply-reviews.py
Lines 275 (patched)
<https://reviews.apache.org/r/65189/#comment275222>

    Can you rename `message` to something else as we already have `with open(message_file,
'w') as message:`.


- Armand Grillet


On Jan. 17, 2018, 12:22 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65189/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2018, 12:22 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Kevin Klues.
> 
> 
> Bugs: MESOS-8447
>     https://issues.apache.org/jira/browse/MESOS-8447
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a shell command to create a file containing the commit
> message for dry-run mode. To minimize platform differences we use
> `printf` instead of `echo`. We output the message on a single line
> for compactness.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 
> 
> 
> Diff: https://reviews.apache.org/r/65189/diff/1/
> 
> 
> Testing
> -------
> 
> Redirected output of `apply-reviews.py --dry-run` to a file and successfully applied
its output with `sh`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message