mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 65109: Fixed a bug relating to lingering executors.
Date Sat, 20 Jan 2018 01:39:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65109/
-----------------------------------------------------------

(Updated Jan. 19, 2018, 5:39 p.m.)


Review request for mesos, Benjamin Mahler and Vinod Kone.


Changes
-------

Patch updated per our review meeting.


Bugs: MESOS-8411
    https://issues.apache.org/jira/browse/MESOS-8411


Repository: mesos


Description
-------

An executor should be shutdown if it has never got any tasks
i.e. all of its initial tasks are killed before launching.
See MESOS-8411.

This patch ensures this by checking an executor's various
tasks queues during task kill and executor registration,
and shutting down executors that had never received any tasks.


Diffs (updated)
-----

  src/slave/constants.hpp e6cb7cc0ccdaaf981eb66defa21b38720f4e1de9 
  src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5 
  src/slave/slave.cpp 43c7955237655accdf869db1b6494a35f77acdb3 


Diff: https://reviews.apache.org/r/65109/diff/4/

Changes: https://reviews.apache.org/r/65109/diff/3-4/


Testing
-------

make check
new tests in #65111


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message