mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 64992: Added SLRP unit tests for profile updates and corner cases.
Date Thu, 18 Jan 2018 17:30:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64992/
-----------------------------------------------------------

(Updated Jan. 18, 2018, 5:30 p.m.)


Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.


Changes
-------

Made changes for style consistency.


Bugs: MESOS-8407
    https://issues.apache.org/jira/browse/MESOS-8407


Repository: mesos


Description
-------

This patch adds the following tests:

`NoResource`: RP updates its state with no resource, and can recover
from a checkpointed state that contains no resource.

`ZeroSizedDisk`: CSI plugin reports a pre-existing volume with
zero capacity.

`SmallDisk`: CSI plugin reports a storage pool and a pre-existing volume
with sizes < 1MB.

`NewProfile`: A new profile is added after RP updates its state.


Diffs (updated)
-----

  src/examples/test_csi_plugin.cpp f6b2c98c44366d5c752aa44bdbf8ae0374a7765c 
  src/tests/storage_local_resource_provider_tests.cpp bbfe95e9818f25fdd5405db3ad2fe355e023f743



Diff: https://reviews.apache.org/r/64992/diff/6/

Changes: https://reviews.apache.org/r/64992/diff/5-6/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message