mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 65122: Fixed race condition in io switchboard for ATTACH_CONTAINER_INPUT call.
Date Wed, 17 Jan 2018 14:14:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65122/
-----------------------------------------------------------

(Updated Jan. 17, 2018, 2:14 p.m.)


Review request for mesos, Alexander Rukletsov, Greg Mann, and Kevin Klues.


Changes
-------

Updated comments.


Bugs: MESOS-7742
    https://issues.apache.org/jira/browse/MESOS-7742


Repository: mesos


Description (updated)
-------

Previously, io switchboard terminated itself after io redirect is
finished and before http response was sent to the agent for
`ATTACH_CONTAINER_INPUT` request. This patch adds a check that an
input connection exists in io redirect completion callback to postpone
termination until `ATTACH_CONTAINER_INPUT` is completely processed.


Diffs (updated)
-----

  src/slave/containerizer/mesos/io/switchboard.cpp 4ef640616d69b91c225206444737a40f9571da55



Diff: https://reviews.apache.org/r/65122/diff/2/

Changes: https://reviews.apache.org/r/65122/diff/1-2/


Testing
-------

sudo make check (Fedora 25)
internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message