mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 65116: Getting Started using the Mesos RPM Binaries.
Date Tue, 16 Jan 2018 19:07:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65116/#review195474
-----------------------------------------------------------



Awesome, thanks Senthil!! Some style comments below.


docs/using-rpm.md
Lines 1-5 (patched)
<https://reviews.apache.org/r/65116/#comment274672>

    Let's rename this file to something a bit more generic, like "binary-packages.md".
    
    We may end up adding a link to the Mesosphere-hosted packages here as well (which include
.deb), or we may end up adding more package formats to our OSS infra.



docs/using-rpm.md
Lines 6 (patched)
<https://reviews.apache.org/r/65116/#comment274675>

    Let's make this heading more generic and include a short explanation, like:
    
    ```
    # Binary Packages
    
    We currently offer RPM packages containing a binary distribution of Mesos.
    ```



docs/using-rpm.md
Lines 8 (patched)
<https://reviews.apache.org/r/65116/#comment274658>

    s/Downloading Mesos RPM Binary/Downloading the Mesos RPM/



docs/using-rpm.md
Lines 10 (patched)
<https://reviews.apache.org/r/65116/#comment274659>

    I don't think the backslash after the "1" is necessary?
    
    s/install/install the/
    
    s/from/from the/
    
    Also, could you terminate the end of this line with a colon?



docs/using-rpm.md
Lines 13 (patched)
<https://reviews.apache.org/r/65116/#comment274660>

    s/it's/its/



docs/using-rpm.md
Lines 18 (patched)
<https://reviews.apache.org/r/65116/#comment274661>

    s/RPM/RPM installation/
    
    s/used as/used as a/



docs/using-rpm.md
Lines 20 (patched)
<https://reviews.apache.org/r/65116/#comment274662>

    s/mesos/Mesos/
    
    Could you terminate this line with a colon?



docs/using-rpm.md
Lines 24 (patched)
<https://reviews.apache.org/r/65116/#comment274663>

    s/mesos/Mesos/g



docs/using-rpm.md
Lines 28 (patched)
<https://reviews.apache.org/r/65116/#comment274666>

    s/mesos/Mesos/
    
    s/Binary RPM/RPM/



docs/using-rpm.md
Lines 29 (patched)
<https://reviews.apache.org/r/65116/#comment274667>

    You can remove the comma here.



site/source/downloads.html.erb
Lines 50 (patched)
<https://reviews.apache.org/r/65116/#comment274668>

    Nit: could you remove the extra space after the bintray URL?



site/source/getting-started.html.md
Lines 15-18 (patched)
<https://reviews.apache.org/r/65116/#comment274671>

    s/How to use rpm build/Binary Packages/
    
    Let's make the text here a bit more generic as well, perhaps:
    
    ```
    Find out how to download <a href="<url>">binary packages</a> of Mesos.
    ```
    
    Also, could you move this section before the "How To Build" section? I think it makes
sense to present the binary packages first.



site/source/getting-started.html.md
Lines 17-18 (patched)
<https://reviews.apache.org/r/65116/#comment274670>

    Just one newline here.


- Greg Mann


On Jan. 12, 2018, 2:36 a.m., Senthil Kumaran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65116/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2018, 2:36 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Getting Started using the Mesos RPM Binaries.
> 
> 
> Diffs
> -----
> 
>   docs/using-rpm.md PRE-CREATION 
>   site/source/downloads.html.erb 758a55225b83d3d38c459d365c94b913f56425ae 
>   site/source/getting-started.html.md b03d80075165020244da9b5f02607355058b9810 
> 
> 
> Diff: https://reviews.apache.org/r/65116/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> $ curl -L "https://dl.bintray.com/mesos/el//7/x86_64/mesos-1.4.1-1.el7.x86_64.rpm" -o
mesos-1.4.1-1.el7.x86_64.rpm
>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
>                                  Dload  Upload   Total   Spent    Left  Speed
>   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
> 100 43.4M  100 43.4M    0     0  49.5M      0 --:--:-- --:--:-- --:--:-- 49.5M
> ```
> 
> And
> 
> ```
> $ sudo yum install mesos-1.4.1-1.el7.x86_64.rpm
> Loaded plugins: langpacks, product-id, search-disabled-repos
> Examining mesos-1.4.1-1.el7.x86_64.rpm: mesos-1.4.1-1.el7.x86_64
> Marking mesos-1.4.1-1.el7.x86_64.rpm to be installed
> Resolving Dependencies
> --> Running transaction check
> ---> Package mesos.x86_64 0:1.4.1-1.el7 will be installed
> --> Processing Dependency: cyrus-sasl-md5 for package: mesos-1.4.1-1.el7.x86_64
> rhui-microsoft-azure-rhel7                                                          
                      | 2.9 kB  00:00:00
> rhui-rhel-7-server-dotnet-rhui-debug-rpms                                           
                      | 3.8 kB  00:00:00
> rhui-rhel-7-server-dotnet-rhui-rpms                                                 
                      | 4.0 kB  00:00:00
> rhui-rhel-7-server-dotnet-rhui-source-rpms                                          
                      | 3.8 kB  00:00:00
> rhui-rhel-7-server-rhui-debug-rpms                                                  
                      | 3.3 kB  00:00:00
> rhui-rhel-7-server-rhui-extras-debug-rpms                                           
                      | 3.2 kB  00:00:00
> rhui-rhel-7-server-rhui-extras-rpms                                                 
                      | 3.4 kB  00:00:00
> rhui-rhel-7-server-rhui-extras-source-rpms                                          
                      | 3.8 kB  00:00:00
> rhui-rhel-7-server-rhui-optional-debug-rpms                                         
                      | 3.3 kB  00:00:00
> rhui-rhel-7-server-rhui-optional-rpms                                               
                      | 3.5 kB  00:00:00
> rhui-rhel-7-server-rhui-optional-source-rpms                                        
                      | 3.8 kB  00:00:00
> rhui-rhel-7-server-rhui-rh-common-debug-rpms                                        
                      | 3.8 kB  00:00:00
> rhui-rhel-7-server-rhui-rh-common-rpms                                              
                      | 3.8 kB  00:00:00
> rhui-rhel-7-server-rhui-rh-common-source-rpms                                       
                      | 3.8 kB  00:00:00
> rhui-rhel-7-server-rhui-rpms                                                        
                      | 3.5 kB  00:00:00
> rhui-rhel-7-server-rhui-source-rpms                                                 
                      | 3.8 kB  00:00:00
> rhui-rhel-7-server-rhui-supplementary-debug-rpms                                    
                      | 3.7 kB  00:00:00
> rhui-rhel-7-server-rhui-supplementary-rpms                                          
                      | 3.4 kB  00:00:00
> rhui-rhel-7-server-rhui-supplementary-source-rpms                                   
                      | 3.8 kB  00:00:00
> rhui-rhel-server-rhui-rhscl-7-debug-rpms                                            
                      | 3.4 kB  00:00:00
> rhui-rhel-server-rhui-rhscl-7-rpms                                                  
                      | 3.5 kB  00:00:00
> rhui-rhel-server-rhui-rhscl-7-source-rpms                                           
                      | 3.8 kB  00:00:00
> (1/16): rhui-rhel-7-server-rhui-extras-rpms/x86_64/updateinfo                       
                      | 223 kB  00:00:00
> (2/16): rhui-rhel-7-server-rhui-extras-rpms/x86_64/primary_db                       
                      | 327 kB  00:00:00
> (3/16): rhui-rhel-7-server-rhui-debug-rpms/7Server/x86_64/updateinfo                
                      | 1.6 MB  00:00:00
> (4/16): rhui-rhel-7-server-rhui-optional-debug-rpms/7Server/x86_64/updateinfo       
                      | 1.2 MB  00:00:00
> (5/16): rhui-rhel-7-server-rhui-optional-rpms/7Server/x86_64/updateinfo             
                      | 1.7 MB  00:00:00
> (6/16): rhui-rhel-7-server-rhui-optional-source-rpms/7Server/x86_64/updateinfo      
                      | 237 kB  00:00:00
> (7/16): rhui-rhel-7-server-rhui-optional-debug-rpms/7Server/x86_64/primary_db       
                      | 2.1 MB  00:00:00
> (8/16): rhui-rhel-7-server-rhui-debug-rpms/7Server/x86_64/primary_db                
                      | 2.8 MB  00:00:00
> (9/16): rhui-rhel-7-server-rhui-rpms/7Server/x86_64/updateinfo                      
                      | 2.4 MB  00:00:00
> (10/16): rhui-rhel-7-server-rhui-optional-rpms/7Server/x86_64/primary_db            
                      | 6.2 MB  00:00:00
> (11/16): rhui-rhel-7-server-rhui-source-rpms/7Server/x86_64/primary_db              
                      | 2.1 MB  00:00:00
> (12/16): rhui-rhel-server-rhui-rhscl-7-rpms/7Server/x86_64/updateinfo               
                      | 876 kB  00:00:00
> (13/16): rhui-rhel-7-server-rhui-optional-source-rpms/7Server/x86_64/primary_db     
                      | 1.3 MB  00:00:00
> (14/16): rhui-rhel-7-server-rhui-rpms/7Server/x86_64/primary_db                     
                      |  46 MB  00:00:00
> (15/16): rhui-rhel-server-rhui-rhscl-7-rpms/7Server/x86_64/primary_db               
                      | 4.8 MB  00:00:00
> (16/16): rhui-rhel-7-server-rhui-source-rpms/7Server/x86_64/updateinfo              
                      | 1.7 MB  00:00:00
> --> Processing Dependency: ntp for package: mesos-1.4.1-1.el7.x86_64
> --> Processing Dependency: libapr-1.so.0()(64bit) for package: mesos-1.4.1-1.el7.x86_64
> --> Processing Dependency: libaprutil-1.so.0()(64bit) for package: mesos-1.4.1-1.el7.x86_64
> --> Processing Dependency: libevent-2.0.so.5()(64bit) for package: mesos-1.4.1-1.el7.x86_64
> --> Processing Dependency: libevent_openssl-2.0.so.5()(64bit) for package: mesos-1.4.1-1.el7.x86_64
> --> Processing Dependency: libevent_pthreads-2.0.so.5()(64bit) for package: mesos-1.4.1-1.el7.x86_64
> --> Processing Dependency: libsvn_delta-1.so.0()(64bit) for package: mesos-1.4.1-1.el7.x86_64
> --> Processing Dependency: libsvn_subr-1.so.0()(64bit) for package: mesos-1.4.1-1.el7.x86_64
> --> Running transaction check
> ---> Package apr.x86_64 0:1.4.8-3.el7_4.1 will be installed
> ---> Package apr-util.x86_64 0:1.5.2-6.el7 will be installed
> ---> Package cyrus-sasl-md5.x86_64 0:2.1.26-21.el7 will be installed
> ---> Package libevent.x86_64 0:2.0.21-4.el7 will be installed
> ---> Package ntp.x86_64 0:4.2.6p5-25.el7_3.2 will be installed
> --> Processing Dependency: libopts.so.25()(64bit) for package: ntp-4.2.6p5-25.el7_3.2.x86_64
> ---> Package subversion-libs.x86_64 0:1.7.14-11.el7_4 will be installed
> --> Processing Dependency: libneon.so.27()(64bit) for package: subversion-libs-1.7.14-11.el7_4.x86_64
> --> Running transaction check
> ---> Package autogen-libopts.x86_64 0:5.18-5.el7 will be installed
> ---> Package neon.x86_64 0:0.30.0-3.el7 will be installed
> --> Processing Dependency: libgnutls.so.28(GNUTLS_1_4)(64bit) for package: neon-0.30.0-3.el7.x86_64
> --> Processing Dependency: libgnutls.so.28(GNUTLS_2_12)(64bit) for package: neon-0.30.0-3.el7.x86_64
> --> Processing Dependency: libgnutls.so.28()(64bit) for package: neon-0.30.0-3.el7.x86_64
> --> Processing Dependency: libpakchois.so.0()(64bit) for package: neon-0.30.0-3.el7.x86_64
> --> Running transaction check
> ---> Package gnutls.x86_64 0:3.3.26-9.el7 will be installed
> --> Processing Dependency: trousers >= 0.3.11.2 for package: gnutls-3.3.26-9.el7.x86_64
> --> Processing Dependency: libhogweed.so.2()(64bit) for package: gnutls-3.3.26-9.el7.x86_64
> --> Processing Dependency: libnettle.so.4()(64bit) for package: gnutls-3.3.26-9.el7.x86_64
> ---> Package pakchois.x86_64 0:0.4-10.el7 will be installed
> --> Running transaction check
> ---> Package nettle.x86_64 0:2.7.1-8.el7 will be installed
> ---> Package trousers.x86_64 0:0.3.14-2.el7 will be installed
> --> Finished Dependency Resolution
> 
> Dependencies Resolved
> 
> ==================================================================================================================================
>  Package                      Arch                Version                         Repository
                                Size
> ==================================================================================================================================
> Installing:
>  mesos                        x86_64              1.4.1-1.el7                     /mesos-1.4.1-1.el7.x86_64
                123 M
> Installing for dependencies:
>  apr                          x86_64              1.4.8-3.el7_4.1                 rhui-rhel-7-server-rhui-rpms
             103 k
>  apr-util                     x86_64              1.5.2-6.el7                     rhui-rhel-7-server-rhui-rpms
              92 k
>  autogen-libopts              x86_64              5.18-5.el7                      rhui-rhel-7-server-rhui-rpms
              66 k
>  cyrus-sasl-md5               x86_64              2.1.26-21.el7                   rhui-rhel-7-server-rhui-rpms
              56 k
>  gnutls                       x86_64              3.3.26-9.el7                    rhui-rhel-7-server-rhui-rpms
             677 k
>  libevent                     x86_64              2.0.21-4.el7                    rhui-rhel-7-server-rhui-rpms
             214 k
>  neon                         x86_64              0.30.0-3.el7                    rhui-rhel-7-server-rhui-rpms
             165 k
>  nettle                       x86_64              2.7.1-8.el7                     rhui-rhel-7-server-rhui-rpms
             327 k
>  ntp                          x86_64              4.2.6p5-25.el7_3.2              rhui-rhel-7-server-rhui-rpms
             547 k
>  pakchois                     x86_64              0.4-10.el7                      rhui-rhel-7-server-rhui-rpms
              14 k
>  subversion-libs              x86_64              1.7.14-11.el7_4                 rhui-rhel-7-server-rhui-rpms
             921 k
>  trousers                     x86_64              0.3.14-2.el7                    rhui-rhel-7-server-rhui-rpms
             289 k
> 
> Transaction Summary
> ==================================================================================================================================
> Install  1 Package (+12 Dependent packages)
> 
> Total size: 126 M
> Total download size: 3.4 M
> Installed size: 132 M
> Is this ok [y/d/N]: Y
> Downloading packages:
> (1/12): autogen-libopts-5.18-5.el7.x86_64.rpm                                       
                      |  66 kB  00:00:00
> (2/12): apr-util-1.5.2-6.el7.x86_64.rpm                                             
                      |  92 kB  00:00:00
> (3/12): cyrus-sasl-md5-2.1.26-21.el7.x86_64.rpm                                     
                      |  56 kB  00:00:00
> (4/12): apr-1.4.8-3.el7_4.1.x86_64.rpm                                              
                      | 103 kB  00:00:00
> (5/12): libevent-2.0.21-4.el7.x86_64.rpm                                            
                      | 214 kB  00:00:00
> (6/12): gnutls-3.3.26-9.el7.x86_64.rpm                                              
                      | 677 kB  00:00:00
> (7/12): neon-0.30.0-3.el7.x86_64.rpm                                                
                      | 165 kB  00:00:00
> (8/12): nettle-2.7.1-8.el7.x86_64.rpm                                               
                      | 327 kB  00:00:00
> (9/12): pakchois-0.4-10.el7.x86_64.rpm                                              
                      |  14 kB  00:00:00
> (10/12): ntp-4.2.6p5-25.el7_3.2.x86_64.rpm                                          
                      | 547 kB  00:00:00
> (11/12): trousers-0.3.14-2.el7.x86_64.rpm                                           
                      | 289 kB  00:00:00
> (12/12): subversion-libs-1.7.14-11.el7_4.x86_64.rpm                                 
                      | 921 kB  00:00:00
> ----------------------------------------------------------------------------------------------------------------------------------
> Total                                                                               
             5.0 MB/s | 3.4 MB  00:00:00
> Running transaction check
> Running transaction test
> Transaction test succeeded
> Running transaction
>   Installing : apr-1.4.8-3.el7_4.1.x86_64                                           
                                        1/13
>   Installing : apr-util-1.5.2-6.el7.x86_64                                          
                                        2/13
>   Installing : pakchois-0.4-10.el7.x86_64                                           
                                        3/13
>   Installing : nettle-2.7.1-8.el7.x86_64                                            
                                        4/13
>   Installing : libevent-2.0.21-4.el7.x86_64                                         
                                        5/13
>   Installing : cyrus-sasl-md5-2.1.26-21.el7.x86_64                                  
                                        6/13
>   Installing : trousers-0.3.14-2.el7.x86_64                                         
                                        7/13
>   Installing : gnutls-3.3.26-9.el7.x86_64                                           
                                        8/13
>   Installing : neon-0.30.0-3.el7.x86_64                                             
                                        9/13
>   Installing : subversion-libs-1.7.14-11.el7_4.x86_64                               
                                       10/13
>   Installing : autogen-libopts-5.18-5.el7.x86_64                                    
                                       11/13
>   Installing : ntp-4.2.6p5-25.el7_3.2.x86_64                                        
                                       12/13
>   Installing : mesos-1.4.1-1.el7.x86_64                                             
                                       13/13
> warning: user mesos does not exist - using root
> warning: group mesos does not exist - using root
> warning: user mesos does not exist - using root
> warning: group mesos does not exist - using root
>   Verifying  : autogen-libopts-5.18-5.el7.x86_64                                    
                                        1/13
>   Verifying  : subversion-libs-1.7.14-11.el7_4.x86_64                               
                                        2/13
>   Verifying  : neon-0.30.0-3.el7.x86_64                                             
                                        3/13
>   Verifying  : trousers-0.3.14-2.el7.x86_64                                         
                                        4/13
>   Verifying  : cyrus-sasl-md5-2.1.26-21.el7.x86_64                                  
                                        5/13
>   Verifying  : libevent-2.0.21-4.el7.x86_64                                         
                                        6/13
>   Verifying  : apr-util-1.5.2-6.el7.x86_64                                          
                                        7/13
>   Verifying  : apr-1.4.8-3.el7_4.1.x86_64                                           
                                        8/13
>   Verifying  : mesos-1.4.1-1.el7.x86_64                                             
                                        9/13
>   Verifying  : nettle-2.7.1-8.el7.x86_64                                            
                                       10/13
>   Verifying  : pakchois-0.4-10.el7.x86_64                                           
                                       11/13
>   Verifying  : ntp-4.2.6p5-25.el7_3.2.x86_64                                        
                                       12/13
>   Verifying  : gnutls-3.3.26-9.el7.x86_64                                           
                                       13/13
> 
> Installed:
>   mesos.x86_64 0:1.4.1-1.el7
> 
> Dependency Installed:
>   apr.x86_64 0:1.4.8-3.el7_4.1              apr-util.x86_64 0:1.5.2-6.el7           
    autogen-libopts.x86_64 0:5.18-5.el7
>   cyrus-sasl-md5.x86_64 0:2.1.26-21.el7     gnutls.x86_64 0:3.3.26-9.el7            
    libevent.x86_64 0:2.0.21-4.el7
>   neon.x86_64 0:0.30.0-3.el7                nettle.x86_64 0:2.7.1-8.el7             
    ntp.x86_64 0:4.2.6p5-25.el7_3.2
>   pakchois.x86_64 0:0.4-10.el7              subversion-libs.x86_64 0:1.7.14-11.el7_4
    trousers.x86_64 0:0.3.14-2.el7
> 
> Complete!
> ```
> 
> 
> Thanks,
> 
> Senthil Kumaran
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message