mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65114: Updated C++ Style Guide.
Date Fri, 12 Jan 2018 04:52:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65114/#review195291
-----------------------------------------------------------



PASS: Mesos patch 65114 was successfully built and tested.

Reviews applied: `['65113', '65114']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65114

- Mesos Reviewbot Windows


On Jan. 12, 2018, 2:07 a.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65114/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2018, 2:07 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, Jie Yu, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added three missing style notes:
> 
> * Use of `::` for global namespace
> * Put `template <typename T>` on own line
> * Prefer `->foo()` to `.get().foo()`
> 
> 
> Diffs
> -----
> 
>   docs/c++-style-guide.md ef80c868fd3f366c998bc33c9f8a664dc35b0336 
> 
> 
> Diff: https://reviews.apache.org/r/65114/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message