mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65048: Logged socket create/connect failures on warning level.
Date Thu, 11 Jan 2018 12:54:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65048/#review195224
-----------------------------------------------------------



PASS: Mesos patch 65048 was successfully built and tested.

Reviews applied: `['65048']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65048

- Mesos Reviewbot Windows


On Jan. 11, 2018, 12:08 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65048/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2018, 12:08 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8247
>     https://issues.apache.org/jira/browse/MESOS-8247
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a socket create or connect failure occurs during link() or send(),
> the reason for error is not propagated to the library user. Also, the
> data being sent or queued is silently dropped on the floor. The socket
> code does not log itself on a higher level when an error situation
> occurs. The only trace is the log entries touched in this patch:
> having them at warning level will significantly simplify debugging.
> 
> This patch also consistently logs send / link target.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 53969a79f5e877b955dcab5c3ab9e508ebe96e88 
> 
> 
> Diff: https://reviews.apache.org/r/65048/diff/2/
> 
> 
> Testing
> -------
> 
> `make check` on Mac OS 10.11.6
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message