mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 65042: Adjusted CSI example framework for recent changes.
Date Tue, 09 Jan 2018 17:14:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65042/#review195044
-----------------------------------------------------------




src/examples/test_csi_user_framework.cpp
Line 94 (original), 96 (patched)
<https://reviews.apache.org/r/65042/#comment274172>

    Why not supplying a single constructor with an `const Option<Credential>&` parameter?



src/examples/test_csi_user_framework.cpp
Line 432 (original), 428 (patched)
<https://reviews.apache.org/r/65042/#comment274173>

    Used the wrong constructor here - this won't authenticate.


- Till Toenshoff


On Jan. 9, 2018, 11:10 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65042/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2018, 11:10 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adjusts the CSI example framework for recent cleanups to
> example frameworks. It now uses generic flag classes which can e.g.,
> parse from both the environment and the command line.
> 
> 
> Diffs
> -----
> 
>   src/examples/test_csi_user_framework.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65042/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message